Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude erroneous payments #467

Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix: exclude erroneous payments #467

merged 2 commits into from
Dec 12, 2023

Conversation

reneaaron
Copy link
Contributor

Fixes #466

@reneaaron reneaaron changed the title fix: exclude errorneous payments fix: exclude erroneous payments Dec 9, 2023
@im-adithya im-adithya marked this pull request as ready for review December 11, 2023 12:38
bumi
bumi reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@bumi bumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we load the other invoice differently and still check that it is there and has the error state?

integration_tests/internal_payment_test.go Outdated Show resolved Hide resolved
@im-adithya im-adithya force-pushed the fix/exclude-errorneous-payments branch from 50cbdc1 to ffff78d Compare December 12, 2023 13:48
@im-adithya im-adithya force-pushed the fix/exclude-errorneous-payments branch from ffff78d to 205fe1a Compare December 12, 2023 13:49
@reneaaron reneaaron merged commit 4eb9f09 into main Dec 12, 2023
3 checks passed
@reneaaron reneaaron deleted the fix/exclude-errorneous-payments branch December 12, 2023 16:47
@reneaaron
Copy link
Contributor Author

Follow-up: #469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@im-adithya im-adithya im-adithya left review comments

@bumi bumi bumi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exclude errorneous payments from APIs
3 participants
@reneaaron @bumi @im-adithya