From 503ee1db6a492f82064ca6c7b315ffdcd38fca61 Mon Sep 17 00:00:00 2001 From: Roman Dmitrienko Date: Sat, 8 Jun 2024 22:32:57 +0200 Subject: [PATCH 01/16] feat: wails release action --- .github/workflows/wails2.yaml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/.github/workflows/wails2.yaml b/.github/workflows/wails2.yaml index d2798f729..fdeaae1b5 100644 --- a/.github/workflows/wails2.yaml +++ b/.github/workflows/wails2.yaml @@ -186,3 +186,26 @@ jobs: path: | *\bin\* if-no-files-found: error + + release_draft: + needs: build + # if: startsWith(github.ref, 'refs/tags/') + runs-on: ubuntu-latest + steps: + - name: Download all artifacts + uses: actions/download-artifact@v4 + with: + path: artifacts + + - name: Create release draft + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + # tag: ${{ github.ref_name }} + tag: ${{ github.sha }} # FIXME: for testing only. + run: | + gh release create "$tag" \ + --repo="$GITHUB_REPOSITORY" \ + --title="${GITHUB_REPOSITORY#*/} ${tag#v}" \ + --generate-notes \ + --draft \ + ./artifacts/* From b65159d65658e60860022743a33f37202c709e8f Mon Sep 17 00:00:00 2001 From: Roman Dmitrienko Date: Sat, 8 Jun 2024 22:53:36 +0200 Subject: [PATCH 02/16] fix: compress windows package --- .github/workflows/wails2.yaml | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/.github/workflows/wails2.yaml b/.github/workflows/wails2.yaml index fdeaae1b5..2b42f4a22 100644 --- a/.github/workflows/wails2.yaml +++ b/.github/workflows/wails2.yaml @@ -15,7 +15,7 @@ jobs: ] runs-on: ${{ matrix.build.os }} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: submodules: recursive @@ -163,6 +163,15 @@ jobs: rm -Rf ./build/bin/* mv ./build/out/albyhub-${{runner.os}}.dmg ./build/bin/ + - name: Make Windows ZIP archive + if: runner.os == 'Windows' + run: | + mkdir -p ./build/out + zip -r -j ./build/out/albyhub-${{runner.os}}.zip ./build/bin/* + rm -Rf ./build/bin/* + mv ./build/out/albyhub-${{runner.os}}.zip ./build/bin/ + shell: bash + - uses: actions/upload-artifact@v4 if: runner.os == 'Linux' with: @@ -184,7 +193,7 @@ jobs: with: name: albyhub-${{runner.os}} path: | - *\bin\* + ./build/bin/albyhub-${{runner.os}}.zip if-no-files-found: error release_draft: From dbe36788b52de40257ad6a055a8666625d60890f Mon Sep 17 00:00:00 2001 From: Roman Dmitrienko Date: Sat, 8 Jun 2024 23:07:46 +0200 Subject: [PATCH 03/16] fix: use 7zip and bump setup-node action version --- .github/workflows/wails2.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/wails2.yaml b/.github/workflows/wails2.yaml index 2b42f4a22..664c7d2aa 100644 --- a/.github/workflows/wails2.yaml +++ b/.github/workflows/wails2.yaml @@ -45,7 +45,7 @@ jobs: run: go get -v -t -d ./... - name: Setup NodeJS - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: '20.x' @@ -167,7 +167,7 @@ jobs: if: runner.os == 'Windows' run: | mkdir -p ./build/out - zip -r -j ./build/out/albyhub-${{runner.os}}.zip ./build/bin/* + 7z a -tzip ./build/out/albyhub-${{runner.os}}.zip ./build/bin/* rm -Rf ./build/bin/* mv ./build/out/albyhub-${{runner.os}}.zip ./build/bin/ shell: bash From baa7f8b3330e246ed3614a3773c23619a9d485c3 Mon Sep 17 00:00:00 2001 From: Roman Dmitrienko Date: Sat, 8 Jun 2024 23:18:35 +0200 Subject: [PATCH 04/16] fix: merge artifacts on download --- .github/workflows/wails2.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/wails2.yaml b/.github/workflows/wails2.yaml index 664c7d2aa..5d79db736 100644 --- a/.github/workflows/wails2.yaml +++ b/.github/workflows/wails2.yaml @@ -205,6 +205,7 @@ jobs: uses: actions/download-artifact@v4 with: path: artifacts + merge-multiple: true - name: Create release draft env: From 65be80dc7a81a28242d2c63f8ec10720e5b76ccd Mon Sep 17 00:00:00 2001 From: Roman Dmitrienko Date: Sun, 16 Jun 2024 21:42:43 +0200 Subject: [PATCH 05/16] chore: refactor actions structure --- .github/workflows/package-raspberry-pi.yml | 4 +- .github/workflows/publish-release.yaml | 50 ++++++++++++++++++++++ .github/workflows/release.yaml | 28 ++++++++++++ .github/workflows/wails2.yaml | 37 ++++++---------- 4 files changed, 93 insertions(+), 26 deletions(-) create mode 100644 .github/workflows/publish-release.yaml create mode 100644 .github/workflows/release.yaml diff --git a/.github/workflows/package-raspberry-pi.yml b/.github/workflows/package-raspberry-pi.yml index dd10d0c03..9d38b7aa8 100644 --- a/.github/workflows/package-raspberry-pi.yml +++ b/.github/workflows/package-raspberry-pi.yml @@ -2,8 +2,8 @@ name: Build package for Raspberry Pi on: push: - release: - types: [published] + + workflow_call: jobs: build: diff --git a/.github/workflows/publish-release.yaml b/.github/workflows/publish-release.yaml new file mode 100644 index 000000000..87f12fc82 --- /dev/null +++ b/.github/workflows/publish-release.yaml @@ -0,0 +1,50 @@ +name: Publish release + +on: + workflow_call: + secrets: + repo-token: + required: true + +jobs: + release_draft: + needs: build + # if: startsWith(github.ref, 'refs/tags/') + runs-on: ubuntu-latest + steps: + - name: Download Raspberry Pi archive + uses: actions/download-artifact@v4 + with: + name: nostr-wallet-connect.zip + path: artifacts + + - name: Download Linux desktop archive + uses: actions/download-artifact@v4 + with: + name: albyhub-Linux + path: artifacts + + - name: Download macOS desktop archive + uses: actions/download-artifact@v4 + with: + name: albyhub-macOS + path: artifacts + + - name: Download Windows desktop archive + uses: actions/download-artifact@v4 + with: + name: albyhub-Windows + path: artifacts + + - name: Create release draft + env: + GH_TOKEN: ${{ secrets.repo-token }} + # tag: ${{ github.ref_name }} + tag: ${{ github.sha }} # FIXME: for testing only. + run: | + gh release create "$tag" \ + --repo="$GITHUB_REPOSITORY" \ + --title="${GITHUB_REPOSITORY#*/} ${tag#v}" \ + --generate-notes \ + --draft \ + ./artifacts/* diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml new file mode 100644 index 000000000..7219eac43 --- /dev/null +++ b/.github/workflows/release.yaml @@ -0,0 +1,28 @@ +name: Release + +on: + # TODO: use release event instead of push + push: + + workflow_dispatch: + +jobs: + build-raspberry-pi: + uses: ./.github/workflows/package-raspberry-pi.yaml + + build-wails: + uses: ./.github/workflows/wails2.yaml + secrets: + APPLE_DEVELOPER_CERTIFICATE_P12_BASE64: ${{ secrets.APPLE_DEVELOPER_CERTIFICATE_P12_BASE64 }} + APPLE_DEVELOPER_CERTIFICATE_PASSWORD: ${{ secrets.APPLE_DEVELOPER_CERTIFICATE_PASSWORD }} + APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }} + APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }} + APPLE_USERNAME: ${{ secrets.APPLE_USERNAME }} + + release-draft: + needs: + - build-raspberry-pi + - build-wails + uses: ./.github/workflows/publish-release.yaml + secrets: + repo-token: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/wails2.yaml b/.github/workflows/wails2.yaml index e5ffd1fc7..366e39962 100644 --- a/.github/workflows/wails2.yaml +++ b/.github/workflows/wails2.yaml @@ -3,6 +3,19 @@ name: Wails build - all platforms on: push: + workflow_call: + secrets: + APPLE_DEVELOPER_CERTIFICATE_P12_BASE64: + required: true + APPLE_DEVELOPER_CERTIFICATE_PASSWORD: + required: true + APPLE_PASSWORD: + required: true + APPLE_TEAM_ID: + required: true + APPLE_USERNAME: + required: true + jobs: build: strategy: @@ -227,27 +240,3 @@ jobs: path: | ./build/bin/albyhub-${{runner.os}}.zip if-no-files-found: error - - release_draft: - needs: build - # if: startsWith(github.ref, 'refs/tags/') - runs-on: ubuntu-latest - steps: - - name: Download all artifacts - uses: actions/download-artifact@v4 - with: - path: artifacts - merge-multiple: true - - - name: Create release draft - env: - GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - # tag: ${{ github.ref_name }} - tag: ${{ github.sha }} # FIXME: for testing only. - run: | - gh release create "$tag" \ - --repo="$GITHUB_REPOSITORY" \ - --title="${GITHUB_REPOSITORY#*/} ${tag#v}" \ - --generate-notes \ - --draft \ - ./artifacts/* From b6fed6df8c46ad08dea8fbe4f1c9b73b18e30e7a Mon Sep 17 00:00:00 2001 From: Roman Dmitrienko Date: Sun, 16 Jun 2024 21:44:26 +0200 Subject: [PATCH 06/16] fix: fix RPi action name --- .github/workflows/release.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 7219eac43..5f5b38817 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -8,7 +8,7 @@ on: jobs: build-raspberry-pi: - uses: ./.github/workflows/package-raspberry-pi.yaml + uses: ./.github/workflows/package-raspberry-pi.yml build-wails: uses: ./.github/workflows/wails2.yaml From 50603ac7dc6f4e2346e603a9cc418cedcf1c7257 Mon Sep 17 00:00:00 2001 From: Roman Dmitrienko Date: Sun, 16 Jun 2024 21:45:48 +0200 Subject: [PATCH 07/16] fix: remove unused dependency from the publish-release action --- .github/workflows/publish-release.yaml | 1 - frontend/package.json | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish-release.yaml b/.github/workflows/publish-release.yaml index 87f12fc82..eca7f65d9 100644 --- a/.github/workflows/publish-release.yaml +++ b/.github/workflows/publish-release.yaml @@ -8,7 +8,6 @@ on: jobs: release_draft: - needs: build # if: startsWith(github.ref, 'refs/tags/') runs-on: ubuntu-latest steps: diff --git a/frontend/package.json b/frontend/package.json index 27f39f839..901c61dbe 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -88,5 +88,6 @@ "typescript": "^5.0.2", "vite": "^4.5.3", "vite-tsconfig-paths": "^4.3.2" - } + }, + "packageManager": "yarn@1.22.19+sha1.4ba7fc5c6e704fce2066ecbfb0b0d8976fe62447" } From f7fe5e3e7026866af1622ef024ff86cb5bcbba90 Mon Sep 17 00:00:00 2001 From: Roman Dmitrienko Date: Mon, 17 Jun 2024 21:21:48 +0200 Subject: [PATCH 08/16] fix: output Raspberry Pi package as tar archive --- .github/workflows/package-raspberry-pi.yml | 20 ++++++++++++++++++++ .github/workflows/publish-release.yaml | 2 +- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/.github/workflows/package-raspberry-pi.yml b/.github/workflows/package-raspberry-pi.yml index 9d38b7aa8..2fc052da6 100644 --- a/.github/workflows/package-raspberry-pi.yml +++ b/.github/workflows/package-raspberry-pi.yml @@ -55,6 +55,7 @@ jobs: ${{ github.workspace }}/armv6-unknown-linux-gnueabihf/bin/armv6-unknown-linux-gnueabihf-strip ./nostr-wallet-connect patchelf --force-rpath --set-rpath '$ORIGIN/lib' ./nostr-wallet-connect + # TODO: remove this; it produces a ZIP archive that loses all permissions (for now, the update.sh script uses this artifact). - name: Archive the artifacts uses: actions/upload-artifact@v4 with: @@ -62,3 +63,22 @@ jobs: path: | lib/ nostr-wallet-connect + + - name: Add Linux perms + run: chmod +x ./nostr-wallet-connect + + # Store everything in a tar archive to preserve permissions + # (specifically, the executable bit on the app executable). + - name: Make output tar archive + run: | + mkdir -p ./tmp + mv ./nostr-wallet-connect ./tmp/ + mv ./lib ./tmp/ + tar -cjf nostr-wallet-connect.tar.bz2 -C ./tmp . + rm -Rf ./tmp + + - name: Upload the package + uses: actions/upload-artifact@v4 + with: + name: nostr-wallet-connect.tar.bz2 + path: nostr-wallet-connect.tar.bz2 diff --git a/.github/workflows/publish-release.yaml b/.github/workflows/publish-release.yaml index eca7f65d9..29bfdd4c6 100644 --- a/.github/workflows/publish-release.yaml +++ b/.github/workflows/publish-release.yaml @@ -14,7 +14,7 @@ jobs: - name: Download Raspberry Pi archive uses: actions/download-artifact@v4 with: - name: nostr-wallet-connect.zip + name: nostr-wallet-connect.tar.bz2 path: artifacts - name: Download Linux desktop archive From d413d41c906e09231a4a960b88c39cd17b982b6d Mon Sep 17 00:00:00 2001 From: Roman Dmitrienko Date: Mon, 17 Jun 2024 21:43:43 +0200 Subject: [PATCH 09/16] fix: undo unrelated change --- frontend/package.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/frontend/package.json b/frontend/package.json index 901c61dbe..27f39f839 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -88,6 +88,5 @@ "typescript": "^5.0.2", "vite": "^4.5.3", "vite-tsconfig-paths": "^4.3.2" - }, - "packageManager": "yarn@1.22.19+sha1.4ba7fc5c6e704fce2066ecbfb0b0d8976fe62447" + } } From 3b0fff4353dffa9bc7299cf5d6aa5b3d6b2444f7 Mon Sep 17 00:00:00 2001 From: Roman Dmitrienko Date: Wed, 19 Jun 2024 22:12:52 +0200 Subject: [PATCH 10/16] feat: publish release when a version tag is pushed --- .github/workflows/publish-release.yaml | 28 ++++++++++++++++++-------- .github/workflows/release.yaml | 5 ++++- 2 files changed, 24 insertions(+), 9 deletions(-) diff --git a/.github/workflows/publish-release.yaml b/.github/workflows/publish-release.yaml index 29bfdd4c6..def7b8eb9 100644 --- a/.github/workflows/publish-release.yaml +++ b/.github/workflows/publish-release.yaml @@ -7,8 +7,7 @@ on: required: true jobs: - release_draft: - # if: startsWith(github.ref, 'refs/tags/') + release: runs-on: ubuntu-latest steps: - name: Download Raspberry Pi archive @@ -36,14 +35,27 @@ jobs: path: artifacts - name: Create release draft + if: github.ref_type != 'tag' env: GH_TOKEN: ${{ secrets.repo-token }} - # tag: ${{ github.ref_name }} - tag: ${{ github.sha }} # FIXME: for testing only. + tag: ${{ github.sha }} run: | - gh release create "$tag" \ - --repo="$GITHUB_REPOSITORY" \ + gh release create \ + --repo="$GITHUB_REPOSITORY" \ --title="${GITHUB_REPOSITORY#*/} ${tag#v}" \ - --generate-notes \ - --draft \ + --generate-notes \ + --draft \ + ./artifacts/* + + - name: Create release + if: github.ref_type == 'tag' + env: + GH_TOKEN: ${{ secrets.repo-token }} + tag: ${{ github.ref_name }} + run: | + gh release create \ + --repo="$GITHUB_REPOSITORY" \ + --title="${GITHUB_REPOSITORY#*/} ${tag#v}" \ + --generate-notes \ + --verify-tag \ ./artifacts/* diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 5f5b38817..f3939ec63 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -1,8 +1,11 @@ name: Release on: - # TODO: use release event instead of push push: + branches: + - master + tags: + - v* workflow_dispatch: From f1ad3df625f9d820a35244a0cb058659a863f03f Mon Sep 17 00:00:00 2001 From: Roman Dmitrienko Date: Wed, 19 Jun 2024 22:19:01 +0200 Subject: [PATCH 11/16] fix: run draft release action on any push --- .github/workflows/release.yaml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index f3939ec63..bf43585c7 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -2,10 +2,6 @@ name: Release on: push: - branches: - - master - tags: - - v* workflow_dispatch: From 1868acbfc8dee3dabdb08653600f8c6e46f2ba22 Mon Sep 17 00:00:00 2001 From: Roland Bewick Date: Fri, 21 Jun 2024 12:19:53 +0700 Subject: [PATCH 12/16] chore: remove old wails workflow --- .github/workflows/wails.yaml | 64 ------------------------------------ 1 file changed, 64 deletions(-) delete mode 100644 .github/workflows/wails.yaml diff --git a/.github/workflows/wails.yaml b/.github/workflows/wails.yaml deleted file mode 100644 index 1c5a41634..000000000 --- a/.github/workflows/wails.yaml +++ /dev/null @@ -1,64 +0,0 @@ -name: Wails build -on: - push: - release: - types: [published] -jobs: - build: - strategy: - fail-fast: false - matrix: - build: - [ - { - name: nostr-wallet-connect, - platform: linux/amd64, - os: ubuntu-latest, - }, - ] - env: - REGISTRY: ghcr.io - IMAGENAME: ${{ github.event.repository.name }} - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - name: Check out code - - name: Setup GoLang - uses: actions/setup-go@v4 - with: - check-latest: true - go-version: 1.21 - # Setup and configure NodeJS - - name: Setup NodeJS - uses: actions/setup-node@v3 - with: - node-version: 20.x - - name: Install Wails - run: go install github.com/wailsapp/wails/v2/cmd/wails@latest - shell: bash - - name: Install Linux Wails deps - run: sudo apt-get update && sudo apt-get install libgtk-3-0 libwebkit2gtk-4.0-dev gcc-aarch64-linux-gnu libgtk-3-dev nsis - shell: bash - - name: Wails Doctor - working-directory: . - run: wails doctor - shell: bash - # Building step - - name: Build App - working-directory: . - run: wails build --platform ${{ matrix.build.platform }} -tags "wails" - #-o ${{ matrix.build.name }} - shell: bash - - uses: actions/upload-artifact@v3 - with: - name: Wails Build ${{runner.os}} nostr-wallet-connect - path: | - */bin/ - *\bin\* - -# - uses: dAppServer/wails-build-action@v2.2 -# with: -# build-name: ${{ matrix.build.name }} -# build-platform: ${{ matrix.build.platform }} -# package: false -# go-version: '1.21' From 93627937a0d25a38788a0592b458b067d113e695 Mon Sep 17 00:00:00 2001 From: Roland Bewick Date: Fri, 21 Jun 2024 12:22:28 +0700 Subject: [PATCH 13/16] chore: rename RPI output --- .github/workflows/package-raspberry-pi.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/package-raspberry-pi.yml b/.github/workflows/package-raspberry-pi.yml index 00702bb08..8329ebc4f 100644 --- a/.github/workflows/package-raspberry-pi.yml +++ b/.github/workflows/package-raspberry-pi.yml @@ -55,7 +55,8 @@ jobs: ${{ github.workspace }}/armv6-unknown-linux-gnueabihf/bin/armv6-unknown-linux-gnueabihf-strip ./nostr-wallet-connect patchelf --force-rpath --set-rpath '$ORIGIN/lib' ./nostr-wallet-connect - # TODO: remove this; it produces a ZIP archive that loses all permissions (for now, the update.sh script uses this artifact). + # TODO: remove this once install.sh and update.sh are updated (they currently use this artifact) + # it produces a ZIP archive that loses all permissions - name: Archive the artifacts uses: actions/upload-artifact@v4 with: @@ -74,11 +75,11 @@ jobs: mkdir -p ./tmp mv ./nostr-wallet-connect ./tmp/ mv ./lib ./tmp/ - tar -cjf nostr-wallet-connect.tar.bz2 -C ./tmp . + tar -cjf nostr-wallet-connect-rpi.tar.bz2 -C ./tmp . rm -Rf ./tmp - name: Upload the package uses: actions/upload-artifact@v4 with: - name: nostr-wallet-connect.tar.bz2 - path: nostr-wallet-connect.tar.bz2 + name: nostr-wallet-connect-rpi.tar.bz2 + path: nostr-wallet-connect-rpi.tar.bz2 From 075144139da8a794e8521d621a7e805e70be2f4a Mon Sep 17 00:00:00 2001 From: Roland Bewick Date: Fri, 21 Jun 2024 12:29:51 +0700 Subject: [PATCH 14/16] chore: rename workflow --- .github/workflows/{publish-release.yaml => create-release.yaml} | 2 +- .github/workflows/release.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) rename .github/workflows/{publish-release.yaml => create-release.yaml} (98%) diff --git a/.github/workflows/publish-release.yaml b/.github/workflows/create-release.yaml similarity index 98% rename from .github/workflows/publish-release.yaml rename to .github/workflows/create-release.yaml index def7b8eb9..de5f6bb28 100644 --- a/.github/workflows/publish-release.yaml +++ b/.github/workflows/create-release.yaml @@ -1,4 +1,4 @@ -name: Publish release +name: Create release on: workflow_call: diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index bf43585c7..d209984f3 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -22,6 +22,6 @@ jobs: needs: - build-raspberry-pi - build-wails - uses: ./.github/workflows/publish-release.yaml + uses: ./.github/workflows/create-release.yaml secrets: repo-token: ${{ secrets.GITHUB_TOKEN }} From c66f54c24254d05a3c2ab1a2f4b4f24ec2d712b6 Mon Sep 17 00:00:00 2001 From: Roland Bewick Date: Fri, 21 Jun 2024 12:31:07 +0700 Subject: [PATCH 15/16] fix: always do a draft release --- .github/workflows/create-release.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/create-release.yaml b/.github/workflows/create-release.yaml index de5f6bb28..4b4027bd4 100644 --- a/.github/workflows/create-release.yaml +++ b/.github/workflows/create-release.yaml @@ -57,5 +57,6 @@ jobs: --repo="$GITHUB_REPOSITORY" \ --title="${GITHUB_REPOSITORY#*/} ${tag#v}" \ --generate-notes \ + --draft \ --verify-tag \ ./artifacts/* From c991c8b5ba0552bca90dbe2d7e110c4ebaea6265 Mon Sep 17 00:00:00 2001 From: Roland Bewick Date: Fri, 21 Jun 2024 12:33:05 +0700 Subject: [PATCH 16/16] chore: rename release steps --- .github/workflows/create-release.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/create-release.yaml b/.github/workflows/create-release.yaml index 4b4027bd4..a87a104bf 100644 --- a/.github/workflows/create-release.yaml +++ b/.github/workflows/create-release.yaml @@ -34,7 +34,7 @@ jobs: name: albyhub-Windows path: artifacts - - name: Create release draft + - name: Create release without tag if: github.ref_type != 'tag' env: GH_TOKEN: ${{ secrets.repo-token }} @@ -47,7 +47,7 @@ jobs: --draft \ ./artifacts/* - - name: Create release + - name: Create release with tag if: github.ref_type == 'tag' env: GH_TOKEN: ${{ secrets.repo-token }}