Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_balance does not follow the spec #216

Open
rolznz opened this issue Jan 14, 2024 · 0 comments
Open

get_balance does not follow the spec #216

rolznz opened this issue Jan 14, 2024 · 0 comments

Comments

@rolznz
Copy link
Contributor

rolznz commented Jan 14, 2024

Example response:

{"result":{"balance":2575000,"max_amount":0,"budget_renewal":""},"result_type":"get_balance"}

This gives an error with rust-nostr:

Err(JSON(Error("Json: unknown variant ``, expected one of `daily`, `weekly`, `monthly`, `yearly`", line: 0, column: 0)))

If not set, the budget_renewal should not be included in the response. Currently it is an empty string.

but should max_amount and budget_renewal just be removed? they are based on permissions which are not part of the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant