Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose v bit in the signature in addition to r,s #117

Closed
bharathrao opened this issue Mar 22, 2021 · 2 comments · May be fixed by #118
Closed

Expose v bit in the signature in addition to r,s #117

bharathrao opened this issue Mar 22, 2021 · 2 comments · May be fixed by #118
Assignees
@markya0616
Labels
question Further information is requested

Comments

@bharathrao
Copy link

FEATURE REQUEST:

Verification of signed messages requires v,r,s components of signature. Currently, a tss signature produces only r and s. The v needs to be computed separately. v can have 4 values. The encoding for v (called recid) depends on the blockchain, whether the address is compressed etc. For bitcoin uncompressed address, the value is 27 or 28 in almost all cases. From compressed addresses it would be 31,32

https://en.bitcoin.it/wiki/BIP_0137#Specification

Ideally, there is a way to generate the v part as well. Blockchain specific encoding is optional. Only values 0,1,2,3 is needed.
@cychuang0924 cychuang0924 added the question Further information is requested label Mar 23, 2021
@markya0616 markya0616 linked a pull request Mar 25, 2021 that will close this issue
crypto/tss: support eth signature #118
Open
6 tasks
@markya0616
Copy link
Contributor

Hello @bharathrao, please refer #118 to generate the v part for ETH blockchain.

@cychuang0924
Copy link
Contributor

This issue has been solved. So close it.

@cychuang0924 cychuang0924 mentioned this issue Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markya0616 markya0616

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

crypto/tss: support eth signature getamis/alice
3 participants
@bharathrao @markya0616 @cychuang0924