Take the method_source code we need and copy it in AppMap, to not depend on method_source or conflict with it in the wild

[symwell]

We want to take the method_source code we need and add it to our repo e.g. lib/appmap/method_source.

Then we can apply the performance fix we want in our repo. That way we can be sure not to conflict with method_source in the wild, and we will get the efficient implementation that we want.

Give proper attribution and then we can be done with it.

https://applanding.slack.com/archives/CQ5JFE1DY/p1662647402949409

[symwell]

I tried to take the method_source code we needed and add it to our repo but it seemed too much work

• copy only some files over, rather than the .git dir or the spec files. It would not include its testcases.
• add attribution
• change it to be under the AppMap module (I think we're supposed to do that.)
• run the testcases, which don't pass now, with some error

It seems easier (2 lines of code change) to point our method_source gem to a custom branch
https://github.com/applandinc/appmap-ruby/compare/sw/use_method_source_from_custom_branch?expand=1

[kgilpin]

But it can still conflict with the `method_source` that may be used by the user's project...

…

On Fri, Sep 9, 2022 at 2:47 PM symwell ***@***.***> wrote: I tried to take the method_source code we needed and add it to our repo but it seemed too much work <https://github.com/applandinc/appmap-ruby/compare/sw/include_method_source_in_appmap?expand=1> - copy only some files over, rather than the .git dir or the spec files. It would not include its testcases. - add attribution - change it to be under the AppMap module (I think we're supposed to do that.) - run the testcases, which don't pass now, with some error It seems easier (2 lines of code change) to point our method_source gem to a custom branch https://github.com/applandinc/appmap-ruby/compare/sw/use_method_source_from_custom_branch?expand=1 — Reply to this email directly, view it on GitHub <#276 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAVC63FDWNKL2MCMXJIX53V5OA4NANCNFSM6AAAAAAQH2LQRY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[kgilpin]

I think it's worth completing that draft - with the code we don't used (such as extracting method source) removed.

…

On Fri, Sep 9, 2022 at 2:51 PM Kevin Gilpin ***@***.***> wrote: But it can still conflict with the `method_source` that may be used by the user's project... On Fri, Sep 9, 2022 at 2:47 PM symwell ***@***.***> wrote: > I tried to take the method_source code we needed and add it to our repo > but it seemed too much work > <https://github.com/applandinc/appmap-ruby/compare/sw/include_method_source_in_appmap?expand=1> > > - copy only some files over, rather than the .git dir or the spec > files. It would not include its testcases. > - add attribution > - change it to be under the AppMap module (I think we're supposed to > do that.) > - run the testcases, which don't pass now, with some error > > It seems easier (2 lines of code change) to point our method_source gem > to a custom branch > > https://github.com/applandinc/appmap-ruby/compare/sw/use_method_source_from_custom_branch?expand=1 > > — > Reply to this email directly, view it on GitHub > <#276 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAVC63FDWNKL2MCMXJIX53V5OA4NANCNFSM6AAAAAAQH2LQRY> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> >

[symwell]

Simpler change that extracts only the code we need frommethod_source with testcases passing.

[kgilpin]

Looks nice. We should raise our own exception class too https://github.com/applandinc/appmap-ruby/compare/sw/part_custom_method_source?expand=1#diff-c7d68f4ec3680a58ebfd3aa08e9e7e1aa17b885e25ea3587e12f99a160b3c09cR75

…

On Fri, Sep 9, 2022 at 3:44 PM symwell ***@***.***> wrote: Simpler change <https://github.com/applandinc/appmap-ruby/compare/sw/part_custom_method_source?expand=1> that extracts only the code we need frommethod_source with testcases passing. — Reply to this email directly, view it on GitHub <#276 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAVC6ZDFBAXJ7EUHB5XGITV5OHRTANCNFSM6AAAAAAQH2LQRY> . You are receiving this because you commented.Message ID: ***@***.***>

[appland-release]

🎉 This issue has been resolved in version 0.90.1 🎉

The release is available on:

• v0.90.1
• GitHub release

Your semantic-release bot 📦🚀