-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No need to pass 'config' to 'host.(un)install' #505
Comments
You are correct. Let's clean that up too. Let's try and force ourselves into there being no need for the Integrations to access the configs on Just for clarity. This is what happens on
Where |
Is the issue not with How would config do custom host installation otherwise? |
@tokejepsen see #501 - with that the Does that answer your question? |
Excellent! |
Remove unneeded `config` variable from host (un)install (closes #505)
When changing the Blender integration so it works with #501, I noticed that the
install()
anduninstall()
functions still expect theconfig
variable. If I'm not mistaken this is not needed anymore and it can be safely removed after changing this line in avalon.pipeline tohost.install()
.Is there a reason not to change this? I can make a pull request if needed.
The text was updated successfully, but these errors were encountered: