Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmony #538

Closed
wants to merge 37 commits into from
Closed

Harmony #538

wants to merge 37 commits into from

Conversation

tokejepsen
Copy link
Collaborator

@tokejepsen tokejepsen commented Mar 30, 2020 •
edited
Loading

What's changed?
This is the Toon Boom Harmony integration which fixes #527

The best introduction to the integration is with the README

hound[bot]
hound bot reviewed Mar 30, 2020
View reviewed changes
avalon/harmony/TB_sceneOpened.js
{
try
{
var func = eval(request["function"]);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eval can be harmful.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how else to evaluate a string function.

@tokejepsen
Copy link
Collaborator Author

This commit marks the completion of the integration.

The hound violation is required to evaluate the code coming from Python.

The Travis error is to do with the module queue which is for threading in Python 3. The error only occurs in Python 2. The question is whether this needs fixing?

@tokejepsen
Copy link
Collaborator Author

BTW the server used for this integration has the potential to be more universal since it just accepts connections over sockets and the messages are json dumps. It could for example be used in Photoshop and After Effects.

This was referenced May 13, 2020
Merged
Merged
@tokejepsen
Copy link
Collaborator Author

Exploring Toon Booms other product "Storyboard Pro" revealed that the two product are built on the same architecture, similar to how NukeStudio/Hiero is similar to Nuke/NukeX.
This means the two products can share a lot of core, but the workflow is different. Currently working on the Storyboard Pro integration, so this PR will eventually turn into a "Toon Boom" PR with both Harmony and Storyboard Pro integration.

@tokejepsen
Copy link
Collaborator Author

This PR has been superseded by the Pype, so it better for the code to come from there.

@tokejepsen tokejepsen closed this Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound hound[bot] hound[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toon Boom Harmony Integration
1 participant
@tokejepsen