Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from eslint to biome #2735

Open
zabil opened this issue Jul 19, 2024 · 1 comment
Open

Migrate from eslint to biome #2735

zabil opened this issue Jul 19, 2024 · 1 comment
Assignees

Comments

@zabil
Copy link
Member

zabil commented Jul 19, 2024

Is your feature request related to a problem? Please describe.
Taiko uses eslint in the current project. However many of the dependencies that eslint uses are
quickly being outdated and show issues in newer versions of node. For example

npm run test-docs                                                                                                                    15:08:34

> [email protected] test-docs
> cd test/docs-tests && node prepare.js && eleventy && cd ./gauge && npm install && npm test

(node:13250) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
[11ty] Writing ./tmp/docs/_site/api/functionReturningPromiseOfObject/index.html from ./tmp/docs/api/api.njk
[11ty] Writing ./tmp/docs/_site/api/functionReturningPromise/index.html from ./tmp/docs/api/api.njk
npm list punycode                                                                                                                                                                              11:05:06
[email protected] /Users/zabilcm/projects/taiko
└─┬ [email protected]
  └─┬ [email protected]
    └─┬ [email protected]
      └── [email protected]

Describe the solution you'd like
Use biome instead of eslint. biome also bundles a formatter.

Note:

This would also involve fixing linting issues in the default setting of biome.

@zabil zabil added this to the Modernize source milestone Jul 19, 2024
@zabil zabil self-assigned this Jul 19, 2024
@zabil zabil mentioned this issue Jul 31, 2024
@zabil
Copy link
Member Author

zabil commented Aug 29, 2024

Eslint is not used in the code anymore but is used in a testing library

npm list eslint
[email protected] /Users/zabilcm/Gauge/taiko
└─┬ [email protected]
  └─┬ [email protected]
    └─┬ @eslint-community/[email protected]
      └── [email protected] deduped

There an open issue on rewire removing eslint. But I don't think that will happen anytime soon. jhnns/rewire#156

Will need to look at alternatives to rewire to completely remove eslint dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant