Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings are not equivalent to JSX strings #552

Open
morgante opened this issue Oct 22, 2024 · 6 comments
Open

Strings are not equivalent to JSX strings #552

morgante opened this issue Oct 22, 2024 · 6 comments

Comments

@morgante
Copy link
Contributor

This not matching is surprising: https://app.grit.io/studio?key=FYK7zmmQarHSELKAIk21Y

Problem is here: https://github.com/getgrit/gritql/blob/main/resources/metavariable-grammars/javascript-metavariable-grammar.js#L726C1-L743C7

@Alex-ley-scrub
Copy link
Contributor

@morgante I could probably do this one.

The link you shared does match? Did it match when you posted this last month? Or has that changed, and if so is that related to my fix for yaml string equivalence having landed/merged between when this issue was created and now?

Or is the issue discussing the difference between these 2 screenshots?

i.e. the link you posted does match with the prop included:
image

but it doesn't match when it is "only" a string literal:
image

Is this ticket considered resolved when the second screenshot/example also matches?

@morgante
Copy link
Contributor Author

Yeah the second case is the problem + what needs to be fixed.

@morgante
Copy link
Contributor Author

/bounty $50

Copy link

algora-pbc bot commented Nov 16, 2024

💎 $50 bounty • Grit

Steps to solve:

  1. Start working: Comment /attempt #552 with your implementation plan
  2. Submit work: Create a pull request including /claim #552 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to getgrit/gritql!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @Alex-ley-scrub Nov 16, 2024, 9:35:42 PM WIP
🟢 @Bhavyajain21 Nov 19, 2024, 7:10:06 PM WIP

@Alex-ley-scrub
Copy link
Contributor

Alex-ley-scrub commented Nov 16, 2024

/attempt #552

Algora profile Completed bounties Tech Active attempts Options
@Alex-ley-scrub 5 grit bounties
Rust, JavaScript
Cancel attempt

Alex-ley-scrub added a commit to Alex-ley-scrub/gritql that referenced this issue Nov 17, 2024
@Bhavyajain21
Copy link

Bhavyajain21 commented Nov 19, 2024

/attempt #552

Algora profile Completed bounties Tech Active attempts Options
@Bhavyajain21 19 bounties from 5 projects
TypeScript, Rust,
JavaScript & more
Cancel attempt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants