-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strings are not equivalent to JSX strings #552
Comments
@morgante I could probably do this one. The link you shared does match? Did it match when you posted this last month? Or has that changed, and if so is that related to my fix for yaml string equivalence having landed/merged between when this issue was created and now? Or is the issue discussing the difference between these 2 screenshots? i.e. the link you posted does match with the prop included: but it doesn't match when it is "only" a string literal: Is this ticket considered resolved when the second screenshot/example also matches? |
Yeah the second case is the problem + what needs to be fixed. |
/bounty $50 |
💎 $50 bounty • GritSteps to solve:
Thank you for contributing to getgrit/gritql! Add a bounty • Share on socials
|
/attempt #552
|
…the jsx strings are parsed see getgrit#552
/attempt #552
|
This not matching is surprising: https://app.grit.io/studio?key=FYK7zmmQarHSELKAIk21Y
Problem is here: https://github.com/getgrit/gritql/blob/main/resources/metavariable-grammars/javascript-metavariable-grammar.js#L726C1-L743C7
The text was updated successfully, but these errors were encountered: