Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View buttons: i18n + query support, component name from key #6901

Draft
wants to merge 3 commits into
base: v5/develop
Choose a base branch
from

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 11, 2025

Description

Todo

  • Do we need query support for more props?
  • Unit tests

Summary of changes

  • Panel\Ui\Button: i18n support for text and title props
  • Panel\Ui\Buttons\ViewButtons and Panel\Ui\Buttons\ViewButton have new optional $model property
  • Kirby query support in Panel\Ui\Buttons\ViewButton for link, dialog and drawer props
  • Deriving the Vue component name from key:
buttons:
  - preview
  retour:
    text: Retour

This first looks up k-retour-view-button and falls back to k-view-button.

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Jan 11, 2025
@distantnative distantnative added this to the 5.0.0-beta.2 milestone Jan 11, 2025
@distantnative distantnative self-assigned this Jan 11, 2025
@distantnative distantnative changed the title View buttons: i18n + query support View buttons: i18n + query support, component name from key Jan 11, 2025
@distantnative distantnative force-pushed the v5/enhancement/view-buttons-query branch from 52b05f0 to 0db0596 Compare January 11, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v5] View buttons with link should accept Query language similiar to page preview
1 participant