Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V5] image block inside of layout row does not get stored after image upload and save #6873

Closed
ralfgoeke opened this issue Dec 17, 2024 · 3 comments · Fixed by #6909
Closed
Milestone

Comments

@ralfgoeke
Copy link

Description

When I'm adding a new layout row, a new image block and then upload an image inside of it, it uploads correctly but the block is not stored to the layout. I can select it and apply the just uploaded image afterwards, though.

Expected behavior
Right upon upload and save, the image should be applied to the block inside the layout without an extra step. Worked in V4.5, I just checked that.

Screenshots
Here's a little screen recording: https://share.cleanshot.com/MrtRK1Kg

To reproduce

In plainkit (V5 Beta1) add this:

# site/blueprints/pages/default.yml

title: Default Page

columns:
  main:
    width: 2/3
    sections:
      fields:
        type: fields
        fields:
          layout:
            label: Layouts
            type: layout
  sidebar:
    width: 1/3
    sections:
      pages:
        type: pages
        template: default
      files:
        type: files

Open panel, got to Home, add a layout and an image block inside it. Upload an image.

Your setup

Kirby Version
5.0.0-beta.1

Console output
none

Your system (please complete the following information)

  • Device: Macbook
  • OS: macOS 15.1.1
  • Browser: Firefox, Chrome
  • Version: current

Additional context
Running DDEV on nginx, PHP 8.3

@afbora
Copy link
Member

afbora commented Dec 20, 2024

IMHO the issue is emitting input removed and block component is not listening the other emits

@bastianallgeier
Copy link
Member

bastianallgeier commented Jan 17, 2025

@afbora you are right. I removed the onInput event to fix another issue related to the way content changes are handled now. The solution seems to be a combination of this PR #6889 and bringing the onInput event back. When we just bring the onInput event back, the new layout row gets entirely deleted.

@bastianallgeier
Copy link
Member

I've fixed it in the same PR #6909 @afbora it all seems to work great now, but could you give it a closer look as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants