Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System view: plugin license status separate column #6896

Draft
wants to merge 1 commit into
base: v5/develop
Choose a base branch
from

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 11, 2025

Description

Todo

  • Default strings don't feel fully right now
    • Should free licenses show Valid license in green or rather something more neutral in passive theme?
    • Should Unkown license be in the status column or rather in the license column?
  • Unit tests

Summary of changes

  • Plugin license status now has its own column in the System view to actually display the LicenseStatus::$label string
    Screenshot 2025-01-11 at 14 02 00

  • LicenseStatus supports new link, dialog, drawer props

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative force-pushed the v5/enhancement/plugin-license branch from 986b9ca to f215df8 Compare January 11, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
2 participants