Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation-Link to /#some-anchor resolves wrong #3646

Open
htgoebel opened this issue Sep 25, 2022 · 2 comments
Open

Navigation-Link to /#some-anchor resolves wrong #3646

htgoebel opened this issue Sep 25, 2022 · 2 comments
Labels

Comments

@htgoebel
Copy link

Environment

Nikola v8.2.3

Description:

When defining

NAVIGATION_LINKS = {
    DEFAULT_LANG: (
        ("/", "Home"),
        ("/#some-anchor", "Subsection"),
    ),
}

this link for “Subsection“ is resolved wrong for sibling pages of /index.html.

  • Correct: /index.html: href="#some-anchor"
  • Wrong: /other-page.html: href="#some-anchor" — leading slash is missing
  • Correct: /dir/page.html: href="/#some-anchor" — leading slash is here

I tried different work-arounds, like /./#some-anchor without success.

@htgoebel htgoebel added the bug label Sep 25, 2022
@sudhir512kj
Copy link

Hello @htgoebel Please label this task for Hacktoberfest and assign it to me. Thank you.

@Kwpolska
Copy link
Member

Kwpolska commented Oct 3, 2022

@sudhir512kj We do not condone Hacktoberfest due to persistent spam in the previous years and will not add a Hacktoberfest label. We welcome your contribution though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants