Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caption on "fotorama_directive" #95

Open
humitos opened this issue Aug 2, 2015 · 2 comments
Open

Caption on "fotorama_directive" #95

humitos opened this issue Aug 2, 2015 · 2 comments

Comments

@humitos
Copy link
Member

humitos commented Aug 2, 2015

How do you think I should implement "Captions" (http://fotorama.io/customize/captions/) in the fotorama_directive (#94)?

I mean, how the user should write the caption to associate with the images?

I was thinking on something like this:

.. fotorama::

  image0.jpg
  Caption for image0.jpg
  image1.jpg
  Caption for image1.jpg
  image2.jpg
  image3.jpg

But the thing is: how I can distinguish if the line is a caption or is a path? I can check if the filepath exists but maybe is a typo instead of a caption :)

Well, that's why I'm asking you guys.

@Kwpolska
Copy link
Member

Kwpolska commented Aug 3, 2015

Put them on one line and use some sort of delimiter, that is unlikely to appear in filenames and that exists on keyboards (\t?)

(also, you should ask in a comment in #94)

@humitos
Copy link
Member Author

humitos commented Sep 12, 2015

I just implemented this but I think there is a bug in the fotorama.io plugin because "thumbnails" and "captions" seems to be incompatible.

http://fotorama.io/customize/thumbnails/#comment-2249947976

Can we merge this PR as it is? and after I get an answer from them, I will add this feature I prefer thumbnails over captions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants