Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC login fails due to Authentik sending state QS and node-openid-client failing a check #1134

Closed
openbrian opened this issue May 1, 2024 · 0 comments · Fixed by #1327
Closed

OIDC login fails due to Authentik sending state QS and node-openid-client failing a check #1134

openbrian opened this issue May 1, 2024 · 0 comments · Fixed by #1327
Assignees
@alxndrsn
Labels
bug

Comments

@openbrian
Copy link

It's all here. https://forum.getodk.org/t/oidc-issue-when-logging-in/46619
openbrian added a commit to openbrian/central-backend that referenced this issue May 1, 2024
@openbrian
improve: Also pass along a state (nonce) paramater.
06763fe 
bug: getodk#1134

It's not needed for CSRF protection because code_challenge does this, but the Authentik IDP will return &state= in the query string.  This will trigger node-openid-client to fail a check.
@openbrian openbrian mentioned this issue May 1, 2024
Closed
2 tasks
openbrian added a commit to openbrian/central-backend that referenced this issue May 1, 2024
@openbrian
improve: Also pass along a state (nonce) paramater.
6776bab 
bug: getodk#1134

It's not needed for CSRF protection because code_challenge does this, but the Authentik IDP will return &state= in the query string.  This will trigger node-openid-client to fail a check.
alxndrsn pushed a commit to alxndrsn/odk-central-backend that referenced this issue Dec 4, 2024
oidc: pass "next" path to IdP as "state"
975b509 
This makes the "next" value more trusted.

Closes getodk#1134
Closes getodk#1135
@alxndrsn alxndrsn mentioned this issue Dec 4, 2024
Merged
4 tasks
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Dec 5, 2024
@matthew-white matthew-white moved this from 🕒 backlog to ✅ done in ODK Central Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alxndrsn alxndrsn

Labels
bug
Projects
ODK Central
Status: ✅ done
Milestone
No milestone
3 participants
@alxndrsn @openbrian @matthew-white