Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unparseable $skiptoken behaviour is undefined #764

Closed
alxndrsn opened this issue Nov 7, 2024 · 0 comments · Fixed by getodk/central-backend#1278
Closed

Unparseable $skiptoken behaviour is undefined #764

alxndrsn opened this issue Nov 7, 2024 · 0 comments · Fixed by getodk/central-backend#1278
Assignees
@alxndrsn
Labels
backend Requires a change to the API server bug nicer error More understandable error messages

Comments

@alxndrsn
Copy link
Contributor

alxndrsn commented Nov 7, 2024

Per getodk/central-backend#1216 (review):

Handle cases where skiptoken is unparsable or doesn't follow our scheme, like $skiptoken=abc. Currently APIs return internal server error, it would be nice to have error that says invalid skiptoken.

cc @sadiqkhoja
@alxndrsn alxndrsn added the bug label Nov 7, 2024
@matthew-white matthew-white transferred this issue from getodk/central-backend Nov 7, 2024
@matthew-white matthew-white added the backend Requires a change to the API server label Nov 7, 2024
This was referenced Nov 8, 2024
Merged
Merged
@alxndrsn alxndrsn self-assigned this Nov 8, 2024
@matthew-white matthew-white added the nicer error More understandable error messages label Nov 9, 2024
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Dec 6, 2024
@matthew-white matthew-white moved this from 🕒 backlog to ✏️ in progress in ODK Central Dec 6, 2024
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alxndrsn alxndrsn

Labels
backend Requires a change to the API server bug nicer error More understandable error messages
Projects
ODK Central
Status: ✅ done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

odata: handle invalid skiptokens alxndrsn/odk-central-backend
2 participants
@alxndrsn @matthew-white