Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry errors without server_name #483

Closed
matthew-white opened this issue May 11, 2022 · 3 comments · Fixed by #642
Closed

Sentry errors without server_name #483

matthew-white opened this issue May 11, 2022 · 3 comments · Fixed by #642

Comments

@matthew-white
Copy link
Member

We're seeing errors in Sentry that don't indicate a server_name, for example, this error from an ODK Cloud server. Because the error doesn't indicate things like the request URL, I'm thinking that it was thrown by the worker mechanism. I think our hope was that 9e41033 would resolve this, but it seems like these errors are still appearing in Sentry.

@yanokwa
Copy link
Member

yanokwa commented Sep 16, 2022

For the record, I'm not optimistic that #521 solves this problem.

The only tags on see on this type of error is environment, handled, level, and mechanism. I see a lot more tags on other errors (e.g., runtime, url, device).

I'm out of my depth here, but it would seem that perhaps workers don't have access to the full Sentry env? @matthew-white would it be worth it to escalate to their support team?

@matthew-white
Copy link
Member Author

I also don't think that #521 solves this problem. For some of the tags you mentioned, I think it's expected that those are missing for workers, because there's no associated request (for example, url). But in other cases, it seems pretty surprising that the tag is missing (for example, runtime). I'm not sure, but it looks like this might be fixed in the latest version of the Sentry SDK: see getsentry/sentry-javascript#5190 (search for server_name).

@matthew-white matthew-white linked a pull request Oct 23, 2022 that will close this issue
@matthew-white
Copy link
Member Author

For posterity, note that #626 effectively reverted the commit 9e41033 mentioned in the issue description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants