Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading en.json5 on Windows #446

Closed
matthew-white opened this issue Apr 30, 2021 · 0 comments · Fixed by #601
Closed

Loading en.json5 on Windows #446

matthew-white opened this issue Apr 30, 2021 · 0 comments · Fixed by #601
Labels
i18n Internationalization infrastructure Changes to core libraries or setup

Comments

@matthew-white
Copy link
Member

We use a single .json5 file, src/locales/en.json5, which we load using json5-loader:

config.module
.rule('json5')
.test(/\/src\/locales\/en\.json5$/)
.type('javascript/auto')
.use('json5')
.loader('json5-loader');

However, the regular expression uses / as the path separator, and it looks like that doesn't work on Windows: https://forum.getodk.org/t/setting-up-locally-odk-central-front-end-and-odk-central-back-end-for-development-on-windows-7/33364

We should be able to modify the regular expression to load en.json5 on Windows. The simplest thing might be to make the regular expression less specific by specifying something like /\.json5$/.

@matthew-white matthew-white added help wanted infrastructure Changes to core libraries or setup i18n Internationalization labels Apr 30, 2021
@matthew-white matthew-white linked a pull request Jan 24, 2022 that will close this issue
@matthew-white matthew-white removed a link to a pull request May 12, 2022
matthew-white added a commit that referenced this issue May 26, 2022
@matthew-white matthew-white linked a pull request May 27, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Internationalization infrastructure Changes to core libraries or setup
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant