Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uploading attachment files alongside a submission #105

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

spwoodcock
Copy link

@spwoodcock spwoodcock commented Nov 21, 2024

This PR

If easier, #103 and #104 could be closed and this reviewed & merged all in one go.

What has been done to verify that this works as intended?

I added a test to upload 3 attachment files to one submission:

image

Why is this the best possible solution? Were any other approaches considered?

  • It solves a requirement provided from an existing issue.
  • The other approach would be to expect the user to create the submission, then upload attachments separately.
  • I think this is a nice addition though, making life significantly easier to creating a submission+attachment combo.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

  • This shouldn't really impact the existing API.
  • It's additive only changes to the submission create.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

  • Updates to the pyodk docs!
  • Will look into that if this PR is approved.

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests
  • run python -m unittest and verified all tests pass
  • run ruff format pyodk tests and ruff check pyodk tests to lint code
  • verified that any code or assets from external sources are properly credited in comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend submission.create to support attachments
1 participant