[Issue #507] Allow non delegate users to declare interest in a patch #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have seen this 👀 but I'm going to leave comments on the issue and discuss things there before looking at this. |
…o review a patch Users interested in reviewing a Patch are linked by the `planning_to_review` attribute on a Patch through the PatchReviewIntention model. Also added a field to State to indicate how long a review intention can last before it expires Signed-off-by: andrepapoti <[email protected]>
…rs to edit it Signed-off-by: andrepapoti <[email protected]>
…ning_to_review' field Signed-off-by: andrepapoti <[email protected]>
Signed-off-by: andrepapoti <[email protected]>
…e PatchReviewIntention for the commenting user Signed-off-by: andrepapoti <[email protected]>
…_review' field Signed-off-by: andrepapoti <[email protected]>
…'patchinterest' Signed-off-by: andrepapoti <[email protected]>
andrepapoti
force-pushed
the
i507
branch
3 times, most recently
from
4e1c212
to
2eb1ae1
Compare
Signed-off-by: andrepapoti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the relation between an user and a patch through the Patch's
interested_usersattribute.This relations happens through the model
PatchInterestthat contains a timestamp for when the interest was declared.Inside a
Patch'sStatethere's now an attribute indicating how long an interest can last before it expires.To remove expired interests async tasks were added using Celery
Serializers and Forms were update to reflect the changes aswell
Related