Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Linting / PEP8 cleanup / CI with Travis CI #2

Open
scls19fr opened this issue Feb 10, 2018 · 2 comments
Open

Code Linting / PEP8 cleanup / CI with Travis CI #2

scls19fr opened this issue Feb 10, 2018 · 2 comments
Labels
enhancement

Comments

@scls19fr
Copy link

scls19fr commented Feb 10, 2018 •
edited

Hello,

a PEP8 cleanup could be a nice improvement.

flake8 can help.

You can check PEP8 with Continuous Integration (Travis CI for example)

See for example
https://github.com/scls19fr/windrose/blob/master/.travis.yml

https://medium.com/python-pandemonium/what-is-flake8-and-why-we-should-use-it-b89bd78073f2

Kind regards
@scls19fr scls19fr changed the title PEP8 cleanup PEP8 cleanup / CI with Travis CI Feb 10, 2018
@scls19fr
Copy link
Author

scls19fr commented Feb 10, 2018 •
edited

This is probably the first issue to tackle.

So you will be able to notice (when fixing others issues) if you (or anyone submitting a PR) don't decrease code quality

@getsanjeev
Copy link
Owner

@scls19fr okay this would be my priority.

@scls19fr scls19fr changed the title PEP8 cleanup / CI with Travis CI Code Linting / PEP8 cleanup / CI with Travis CI Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scls19fr @getsanjeev