Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS 13 symbols #5

Open
philipphofmann opened this issue Sep 1, 2022 · 6 comments
Open

macOS 13 symbols #5

philipphofmann opened this issue Sep 1, 2022 · 6 comments

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Sep 1, 2022

I just wanted to upload the macOS 13 symbols manually. I tried to look for the dyld cache files in /System/Library/dyld/, but in macOS 13, they are no longer located in this folder. Is our current solution able to get the macOS 13 dsyms? If yes, please close this issue, if not let's discuss how we can make this happen.

A possible solution to get the dyld files dortania/OpenCore-Legacy-Patcher#998 (comment).

@phacops
Copy link
Collaborator

phacops commented Sep 1, 2022

I think the automated process will still work as it's only removing the dyld folder from what's shipped to customers but not the IPSW file we can download from Apple. We should verify that once the file is published through ipsw.me once macOS 13 is released.

@philipphofmann
Copy link
Member Author

I just tried extracting the dSYMs from the dyld with the dyld-shared-cache-extractor, and it worked. The location of the dyld changed, though, see keith/dyld-shared-cache-extractor#4.

/System/Volumes/Preboot/{Ventura Preboot UUID}/cryptex1/current:
  - os.dmg

I think we need to adapt these lines of code

shared_cache_dir = os.path.join(
volume_path,
"System",
"Library",
"dyld",
)

@philipphofmann
Copy link
Member Author

Apple released macOS 13 yesterday, but I don't see the dSYMs in our bucket. I only see

  • 13.0.0-beta.6_arm64e
  • 13.0.0-beta.6_x86_64

GH actions fails with

[sentry] Need to download and process 13.0_22A380_arm64e
[sentry] Downloading https://updates.cdn-apple.com/2022FallFCS/fullrestores/012-92188/2C38BCD1-2BFF-4A10-B358-94E8E28BE805/UniversalMac_13.0_22A380_Restore.ipsw
[sentry] Extracting /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/_sentry_ipsw_archives_psse560l/UniversalMac_13.0_22A380_Restore.ipsw to /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/_sentry_ipsw_extract_dir_mv3ji6cs
[sentry] Found image for 13.0 (22A380) in /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/_sentry_ipsw_extract_dir_mv3ji6cs
[sentry] Mounting /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/_sentry_ipsw_extract_dir_mv3ji6cs/078-35934-215.dmg
hdiutil: attach failed - no mountable file systems
[sentry] Unmounting /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/_sentry_ipsw_extract_dir_mv3ji6cs/078-35934-215.dmg
Traceback (most recent call last):
  File "/Users/runner/work/apple-system-symbols-upload/apple-system-symbols-upload/import_system_symbols_from_ipsw.py", line 308, in process_one_dmg
    for filename in os.listdir(shared_cache_dir):
FileNotFoundError: [Errno 2] No such file or directory: 'System/Library/dyld'

@phacops, could you please have a look?

@philipphofmann
Copy link
Member Author

@phacops, didn't you fix that with #11?

@phacops
Copy link
Collaborator

phacops commented Oct 28, 2022

#11 is a bit unrelated to that. The issue here is related to the GitHub action runner. I don't have a formal fix for that but we have a workaround (run the script locally).

In any case, This can be closed because the issue I'm describing is not tied to macOS 13, the GitHub action runner can't mount any DMG we download.

@philipphofmann
Copy link
Member Author

But the issue is about getting the dSYMs for macOS 13; we have to run the script locally. So I think this issue is not fixed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants