Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent releasing beta versions and newer major overrides for Brew releases #391

Open
kamilogorek opened this issue May 8, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@kamilogorek
Copy link
Contributor

  1. Our Brew releasing workflow doesn't understand to not publish itself when a newer major is present, and it overrides it, which makes patches for older versions override the latest version.
  2. Brew doesn't understand pre-releases, and it tries to install 2.0.0-beta.0 which is not available at the time of doing Crafts pre-prelease publish.

beta ref: getsentry/homebrew-tools#3
major ref: getsentry/homebrew-tools#5

@lforst
Copy link
Member

lforst commented Nov 27, 2023

Adding: It seems like our brew target publishes pre-release versions, like alphas, as latest. Which is no bueno.

@armcknight
Copy link
Member

armcknight commented Jan 24, 2024

Regarding (1), Brew doesn't have a concept of release channels like you can use with gem install --version or pip install example-package>=2.0.1 that we could use to have parallel latest releases in multiple support series like 1.x.x and 2.x.x. The way other orgs solve this is by creating entirely separate formulas, like https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/p/[email protected] vs https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/p/[email protected]. AFAIK the @s aren't a feature of homebrew, they're part of the formula name used to namespace the different implicit major support series channels.

So what we really want is a separate homebrew formula for sentry-cli@1 and sentry-cli@2 that can each have their own "latest" release.

ETA: PostgreSQL use an option keg_only :versioned_formula with the all but their postgresql@14 formula, which I think is how they are supporting a workflow where brew install postgres will select the postgres@14 fomula (because they also have later versions too, 15 and 16, that I guess aren't their "officially supported latest major" ¯\(ツ)/¯ )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants