Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): Increase artifact polling interval and max retries #484

Closed
wants to merge 3 commits into from

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Aug 3, 2023

As outlined in #482 by @BYK we should increase the time we wait for the build artifacts so that the publishing process doesn't fail if GH didn't upload artifacts within 30s.

closes #482

@BYK
Copy link
Member

BYK commented Aug 3, 2023

Looks like you need to update the test snapshots now:

yarn test -u

@Lms24
Copy link
Member Author

Lms24 commented Aug 3, 2023

Hmm I don't know why the pr-check job is failing. Anyone have an idea why/how to fix?

Comment on lines 2 to 8
import { getGitHubClient } from '../../utils/githubApi';
import {
GitHubArtifactProvider,
ArtifactItem,
lazyRequest,
lazyRequestCallback,
} from '../github';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reformat makes it really difficult to see what changed here -- can you discard those changes?

can probably set up formatting separately

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lms24
Copy link
Member Author

Lms24 commented Aug 4, 2023

I'd love to 🚢 but I can't merge as long as the pr-check job is failing. I have 0 context around google cloud build and the logs don't really help me (I'm probably missing something). Any ideas what could be going wrong?

@asottile-sentry
Copy link
Member

I killed cloudbuild so this should be better now

@Lms24
Copy link
Member Author

Lms24 commented Aug 9, 2023

Closing due to #482 (comment)

@Lms24 Lms24 closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GH Artifact lookup times out
4 participants