Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CocoaPods to 1.16.2 #573

Closed
philipphofmann opened this issue Nov 25, 2024 · 4 comments · Fixed by #594
Closed

Update CocoaPods to 1.16.2 #573

philipphofmann opened this issue Nov 25, 2024 · 4 comments · Fixed by #594
Assignees
@philipphofmann

Comments

@philipphofmann
Copy link
Member

We can't update CocoaPods to 1.16.2 cause it fails with

ERROR | [iOS] unknown: Encountered an unknown error (Unable to locate the executable `rsync`) during validation.

so we had to roll back to 1.14.2. See #570.

We can try adding rsync here and double-check with the docker image locally to see if it works before opening a PR.

craft/Dockerfile

Lines 28 to 42 in 272a995

RUN apt-get -qq update \
&& apt-get install -y --no-install-recommends \
apt-transport-https \
build-essential \
curl \
default-jdk-headless \
dirmngr \
gnupg \
git \
python3-packaging \
python3-venv \
ruby-full \
jq \
unzip \
maven \

@philipphofmann philipphofmann self-assigned this Nov 25, 2024
@BYK
Copy link
Member

BYK commented Nov 27, 2024

@philipphofmann need any help with this?

@philipphofmann
Copy link
Member Author

Thanks for asking @BYK. Nope, I don't need help; all I need is time. I mean, if you have the bandwidth, I would appreciate it a lot.

BYK added a commit that referenced this issue Dec 4, 2024
@BYK
feat: Add rsync to Docker image
59281a9 
Related #573
@BYK BYK mentioned this issue Dec 4, 2024
Merged
BYK added a commit that referenced this issue Dec 4, 2024
@BYK
feat: Add rsync to Docker image
ff6224c 
Related #573
BYK added a commit that referenced this issue Dec 4, 2024
@BYK
feat: Add rsync to Docker image (#575)
9eb7ea5 
Related #573
@BYK
Copy link
Member

BYK commented Dec 4, 2024

@philipphofmann Added rsync!

@philipphofmann
Copy link
Member Author

Thanks, @BYK. Now, I can update CocoaPods and try it locally before opening a PR.

@github-project-automation github-project-automation bot moved this to Needs Discussion in Mobile SDKs Mar 20, 2025
@philipphofmann philipphofmann moved this from Needs Discussion to In Progress in Mobile SDKs Mar 20, 2025
philipphofmann added a commit that referenced this issue Mar 21, 2025
@philipphofmann
chore: Update CocoaPods from 1.14.2 to 1.16.2
da1ee5d 
We added the missing rsync dependency via GH-575. We can update
CocoaPods now.

Fixes GH-573
@philipphofmann philipphofmann mentioned this issue Mar 21, 2025
Merged
philipphofmann added a commit that referenced this issue Mar 25, 2025
@philipphofmann
chore: Update CocoaPods from 1.14.2 to 1.16.2 (#594)
3987ca5 
We added the missing rsync dependency via GH-575. We can update
CocoaPods now.

Fixes GH-573
@github-project-automation github-project-automation bot moved this from In Progress to Done in Mobile SDKs Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipphofmann philipphofmann

Labels
None yet
Projects
Mobile SDKs
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Update CocoaPods from 1.14.2 to 1.16.2 getsentry/craft
2 participants
@BYK @philipphofmann