Skip to content

Commit 0351065

Browse files
fix: Remove unused SentryFrame.instruction (#6504)
The property isn't used anywhere in the SDK, we can remove it. Fixes GH-4738
1 parent 24a1eec commit 0351065

File tree

3 files changed

+1
-88
lines changed

3 files changed

+1
-88
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
- Removes `enablePerformanceV2` option and makes this the default. The app start duration will now finish when the first frame is drawn instead of when the OS posts the UIWindowDidBecomeVisibleNotification. (#6008)
2121
- Removes enableTracing property from SentryOptions (#5694)
2222
- Structured Logs: Move options out of experimental (#6359)
23+
- Remove unused `SentryFrame.instruction` property (#6504)
2324
- Remove `uuid` and `name` of `SentryDebugMeta` (#6512) Use `debugID` instead of `uuid` and `codeFile` instead of `name`.
2425
- Enable enablePreWarmedAppStartTracing by default (#6508). With this option enabled, the SDK collects [prewarmed app starts](https://docs.sentry.io/platforms/apple/tracing/instrumentation/automatic-instrumentation/#prewarmed-app-start-tracing).
2526

Sources/Sentry/Public/SentryFrame.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,6 @@ NS_SWIFT_NAME(Frame)
5959
*/
6060
@property (nonatomic, copy) NSString *_Nullable instructionAddress;
6161

62-
/**
63-
* InstructionAddress of the frame
64-
*/
65-
@property (nonatomic) NSUInteger instruction;
66-
6762
/**
6863
* User for react native, will be ignored for cocoa frames
6964
*/

sdk_api.json

Lines changed: 0 additions & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -8652,89 +8652,6 @@
86528652
}
86538653
]
86548654
},
8655-
{
8656-
"kind": "Var",
8657-
"name": "instruction",
8658-
"printedName": "instruction",
8659-
"children": [
8660-
{
8661-
"kind": "TypeNominal",
8662-
"name": "Int",
8663-
"printedName": "Swift.Int",
8664-
"usr": "s:Si"
8665-
}
8666-
],
8667-
"declKind": "Var",
8668-
"usr": "c:objc(cs)SentryFrame(py)instruction",
8669-
"moduleName": "Sentry",
8670-
"isOpen": true,
8671-
"objc_name": "instruction",
8672-
"declAttributes": [
8673-
"ObjC",
8674-
"Dynamic"
8675-
],
8676-
"accessors": [
8677-
{
8678-
"kind": "Accessor",
8679-
"name": "Get",
8680-
"printedName": "Get()",
8681-
"children": [
8682-
{
8683-
"kind": "TypeNominal",
8684-
"name": "Int",
8685-
"printedName": "Swift.Int",
8686-
"usr": "s:Si"
8687-
}
8688-
],
8689-
"declKind": "Accessor",
8690-
"usr": "c:objc(cs)SentryFrame(im)instruction",
8691-
"moduleName": "Sentry",
8692-
"isOpen": true,
8693-
"objc_name": "instruction",
8694-
"declAttributes": [
8695-
"DiscardableResult",
8696-
"ObjC",
8697-
"Dynamic"
8698-
],
8699-
"accessorKind": "get"
8700-
},
8701-
{
8702-
"kind": "Accessor",
8703-
"name": "Set",
8704-
"printedName": "Set()",
8705-
"children": [
8706-
{
8707-
"kind": "TypeNameAlias",
8708-
"name": "Void",
8709-
"printedName": "Swift.Void",
8710-
"children": [
8711-
{
8712-
"kind": "TypeNominal",
8713-
"name": "Void",
8714-
"printedName": "()"
8715-
}
8716-
]
8717-
},
8718-
{
8719-
"kind": "TypeNominal",
8720-
"name": "Int",
8721-
"printedName": "Swift.Int",
8722-
"usr": "s:Si"
8723-
}
8724-
],
8725-
"declKind": "Accessor",
8726-
"usr": "c:objc(cs)SentryFrame(im)setInstruction:",
8727-
"moduleName": "Sentry",
8728-
"isOpen": true,
8729-
"objc_name": "setInstruction:",
8730-
"declAttributes": [
8731-
"ObjC",
8732-
"Dynamic"
8733-
],
8734-
"accessorKind": "set"
8735-
}
8736-
]
8737-
},
87388655
{
87398656
"kind": "Var",
87408657
"name": "lineNumber",

0 commit comments

Comments
 (0)