Skip to content

Remove SentryFrame.instruction #4738

@philipphofmann

Description

@philipphofmann

Description

The event payload in the develop docs doesn't mention this property, and SentryFrame.serialize doesn't use it. Therefore, we can remove it in the next major.

- (NSDictionary<NSString *, id> *)serialize
{
NSMutableDictionary *serializedData = [NSMutableDictionary new];
[serializedData setValue:self.symbolAddress forKey:@"symbol_addr"];
[serializedData setValue:self.fileName forKey:@"filename"];
[serializedData setValue:self.function forKey:@"function"];
[serializedData setValue:self.module forKey:@"module"];
[serializedData setValue:self.lineNumber forKey:@"lineno"];
[serializedData setValue:self.columnNumber forKey:@"colno"];
[serializedData setValue:self.package forKey:@"package"];
[serializedData setValue:self.imageAddress forKey:@"image_addr"];
[serializedData setValue:self.instructionAddress forKey:@"instruction_addr"];
[serializedData setValue:self.platform forKey:@"platform"];
[SentryDictionary setBoolValue:self.inApp forKey:@"in_app" intoDictionary:serializedData];
[SentryDictionary setBoolValue:self.stackStart
forKey:@"stack_start"
intoDictionary:serializedData];
return serializedData;
}

Metadata

Metadata

Labels

Breaking-changeshould go in a major release (breaks apps, changes default configs in a major way)Cocoa

Projects

Status

Backlog

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions