Add beforeCapture for View Hierarchy
#2523
Merged
+289
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2523 +/- ##
==========================================
+ Coverage 87.15% 92.02% +4.87%
==========================================
Files 266 89 -177
Lines 9432 3099 -6333
==========================================
- Hits 8220 2852 -5368
+ Misses 1212 247 -965 ☔ View full report in Codecov by Sentry. |
denrase
requested review from
krystofwoldrich,
stefanosiano and
buenaflor
as code owners
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 43abc4f | 406.54 ms | 475.53 ms | 68.99 ms |
| 559d28f | 302.35 ms | 339.53 ms | 37.18 ms |
| 7f75f32 | 347.36 ms | 419.58 ms | 72.22 ms |
| e0f6628 | 380.21 ms | 450.39 ms | 70.17 ms |
| d5696bf | 424.06 ms | 425.58 ms | 1.52 ms |
| 0764150 | 469.49 ms | 541.86 ms | 72.37 ms |
| be8cafe | 405.40 ms | 470.95 ms | 65.56 ms |
| d089990 | 361.67 ms | 442.50 ms | 80.83 ms |
| 2261c15 | 370.00 ms | 455.88 ms | 85.88 ms |
| eecbbca | 324.37 ms | 352.49 ms | 28.12 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 43abc4f | 6.35 MiB | 7.34 MiB | 1007.72 KiB |
| 559d28f | 5.94 MiB | 6.92 MiB | 1001.70 KiB |
| 7f75f32 | 6.26 MiB | 7.20 MiB | 959.18 KiB |
| e0f6628 | 6.33 MiB | 7.29 MiB | 987.23 KiB |
| d5696bf | 6.49 MiB | 7.55 MiB | 1.06 MiB |
| 0764150 | 6.46 MiB | 7.48 MiB | 1.01 MiB |
| be8cafe | 6.34 MiB | 7.29 MiB | 969.12 KiB |
| d089990 | 6.34 MiB | 7.28 MiB | 967.79 KiB |
| 2261c15 | 6.27 MiB | 7.20 MiB | 957.75 KiB |
| eecbbca | 5.94 MiB | 6.89 MiB | 975.78 KiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4d75417 | 1240.57 ms | 1261.76 ms | 21.19 ms |
| 24b6e60 | 1250.69 ms | 1268.63 ms | 17.94 ms |
| 08a7b4f | 1277.10 ms | 1303.37 ms | 26.27 ms |
| 333903e | 1251.15 ms | 1270.21 ms | 19.06 ms |
| bd37365 | 1236.22 ms | 1243.27 ms | 7.04 ms |
| 6325c3b | 1266.52 ms | 1291.06 ms | 24.54 ms |
| 6a5a65d | 1237.22 ms | 1250.29 ms | 13.07 ms |
| aed5947 | 1268.67 ms | 1281.10 ms | 12.43 ms |
| 7954fb3 | 1247.20 ms | 1272.15 ms | 24.94 ms |
| ed2ae08 | 1222.10 ms | 1226.57 ms | 4.47 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4d75417 | 8.38 MiB | 9.71 MiB | 1.34 MiB |
| 24b6e60 | 8.32 MiB | 9.38 MiB | 1.06 MiB |
| 08a7b4f | 8.16 MiB | 9.16 MiB | 1.01 MiB |
| 333903e | 8.10 MiB | 9.16 MiB | 1.06 MiB |
| bd37365 | 8.28 MiB | 9.34 MiB | 1.06 MiB |
| 6325c3b | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 6a5a65d | 8.34 MiB | 9.65 MiB | 1.31 MiB |
| aed5947 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 7954fb3 | 8.38 MiB | 9.75 MiB | 1.37 MiB |
| ed2ae08 | 8.28 MiB | 9.34 MiB | 1.06 MiB |
3 tasks
buenaflor
reviewed
Dec 20, 2024
flutter/lib/src/view_hierarchy/view_hierarchy_event_processor.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Add
beforeCapturefor View Hierarchy💡 Motivation and Context
Closes #2513
💚 How did you test it?
Tests
📝 Checklist
sendDefaultPiiis enabled