From 13efc14a18392f058afc6dc83deff6f346d11772 Mon Sep 17 00:00:00 2001
From: abdellah hariti <haritiabdellah@gmail.com>
Date: Mon, 3 Jun 2024 16:53:52 +0100
Subject: [PATCH] Fix onboarding options jumping (#10236)

* fix: don't add padding to onboarding options when they're sticking
* delete console.log
* fix typo
* remove rounded corners from OnboardingOptionButtons

---------

Co-authored-by: Stephanie Anderson <stephanie.anderson@sentry.io>
---
 src/components/onboarding/index.tsx | 33 +++--------------------------
 1 file changed, 3 insertions(+), 30 deletions(-)

diff --git a/src/components/onboarding/index.tsx b/src/components/onboarding/index.tsx
index 95eeb4145933c9..9d5aa2807a3091 100644
--- a/src/components/onboarding/index.tsx
+++ b/src/components/onboarding/index.tsx
@@ -1,6 +1,6 @@
 'use client';
 
-import {ReactNode, useEffect, useReducer, useRef, useState} from 'react';
+import {ReactNode, useEffect, useReducer, useState} from 'react';
 import {QuestionMarkCircledIcon} from '@radix-ui/react-icons';
 import * as Tooltip from '@radix-ui/react-tooltip';
 import {Button, Checkbox, Theme} from '@radix-ui/themes';
@@ -176,8 +176,6 @@ export function OnboardingOptionButtons({
         `[data-onboarding-option="${option.id}"]`
       );
       targetElements.forEach(el => {
-        console.log('el', el.dataset);
-
         const hiddenForThisOption = el.dataset.hideForThisOption === 'true';
         if (hiddenForThisOption) {
           el.classList.toggle('hidden', option.checked);
@@ -211,35 +209,10 @@ export function OnboardingOptionButtons({
         });
       }
     });
-  }, [options, touchOptions]);
-
-  const buttonsRef = useRef<HTMLDivElement>(null);
-  const containerTopPx = 80;
-  const [isSticky, setIsSticky] = useState(false);
-
-  useEffect(() => {
-    const observer = new IntersectionObserver(
-      function ([buttonsContainer]) {
-        setIsSticky(!buttonsContainer.isIntersecting);
-      },
-      {
-        // the 1 exptra px is important to trigger the observer
-        // https://stackoverflow.com/questions/16302483/event-to-detect-when-positionsticky-is-triggered
-        rootMargin: `-${containerTopPx + 1}px 0px 0px 0px`,
-        threshold: [1],
-      }
-    );
-
-    observer.observe(buttonsRef.current!);
-  }, []);
+  }, [options, touchedOptions]);
 
   return (
-    <div
-      ref={buttonsRef}
-      className={`flex flex-wrap gap-3 py-2 bg-white/90 sticky top-[80px] z-[1000] rounded shadow-[var(--shadow-6)] transition ${
-        isSticky ? 'px-2 backdrop-blur' : ''
-      }`}
-    >
+    <div className="flex flex-wrap gap-3 py-2 bg-white/90 sticky top-[80px] z-[1000] shadow-[var(--shadow-6)] transition">
       {options.map(option => (
         <Button
           variant="surface"