Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate titles on Arcade embeds #11714

Closed
a-hariti opened this issue Nov 2, 2024 · 3 comments · Fixed by #11722
Closed

Duplicate titles on Arcade embeds #11714

a-hariti opened this issue Nov 2, 2024 · 3 comments · Fixed by #11722
Assignees

Comments

@a-hariti
Copy link
Collaborator

a-hariti commented Nov 2, 2024

Problem Statement

some (all?) iframes from arcade.software have duplicate title attributes and that results in a lot of noise on build logs like this:

▲ [WARNING] Duplicate key "title" in object literal [duplicate-object-key]

    _mdx_bundler_entry_point-65616264-ad49-45a8-9f26-185df5a53898.mdx:126:8:
      126 │         title: "Trace View - Tabbing"
          ╵         ~~~~~

  The original key "title" is here:

    _mdx_bundler_entry_point-65616264-ad49-45a8-9f26-185df5a53898.mdx:111:8:
      111 │         title: "Sentry",
          ╵         ~~~~~

Solution Brainstorm

dedupe titles

is there a heuristic to know which one to keep? (first or second) or do we have to decide on a case by case basis?

cc @stephanie-anderson

@a-hariti a-hariti self-assigned this Nov 2, 2024
@stephanie-anderson
Copy link
Contributor

I would remove all the title attributes of iframes, on the trace view page are three iframes, those titles are irrelevant

@stephanie-anderson
Copy link
Contributor

I think we should also create a component for those embeddings - but we can do that in a separate PR

@a-hariti
Copy link
Collaborator Author

a-hariti commented Nov 4, 2024

yeah, will remove lots of redundancy 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants