Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Expo manual setup steps #8631

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Conversation

krystofwoldrich
Copy link
Member

Sentry RN SDK will support Expo projects out of the box.

@krystofwoldrich krystofwoldrich requested a review from a team as a code owner December 5, 2023 08:40
Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 4:40pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs-next ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 4:40pm

Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small grammar tweaks :)

src/platforms/react-native/manual-setup/expo.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/manual-setup/expo.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/manual-setup/expo.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/manual-setup/expo.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/manual-setup/expo.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/manual-setup/expo.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/manual-setup/expo.mdx Outdated Show resolved Hide resolved
@krystofwoldrich
Copy link
Member Author

@shanamatthews Could you give it one more look, I had to remove some parts as they are not ready yet.

@shanamatthews
Copy link
Contributor

Hey @krystofwoldrich - did you forget to push your changes? I don't see any new commits since I reviewed last :)

@krystofwoldrich
Copy link
Member Author

@shanamatthews Yes 😅, thanks for the message, now it's here.

Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple suggestions for headers that I missed previously.

src/platforms/react-native/manual-setup/expo.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/manual-setup/expo.mdx Outdated Show resolved Hide resolved
@krystofwoldrich krystofwoldrich enabled auto-merge (squash) December 7, 2023 16:35
@krystofwoldrich krystofwoldrich merged commit 1d45780 into master Dec 7, 2023
9 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-add-expo-manual-steps branch December 7, 2023 16:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants