Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to drop errors instead of going into sync mode #848

Open
ananthakumaran opened this issue Jan 8, 2025 · 0 comments · May be fixed by #849
Open

Add ability to drop errors instead of going into sync mode #848

ananthakumaran opened this issue Jan 8, 2025 · 0 comments · May be fixed by #849

Comments

@ananthakumaran
Copy link

  location: [
    initial_call: {:proc_lib, :init_p, 5},
    current_stacktrace: [
      {Process, :sleep, 1, [file: ~c"lib/process.ex", line: 303]},
      {Sentry.Transport, :post_envelope_with_retries, 5,
       [file: ~c"lib/sentry/transport.ex", line: 41]},
      {Sentry.Client, :encode_and_send, 4,
       [file: ~c"lib/sentry/client.ex", line: 228]},
      {Sentry.Client, :send_event, 2,
       [file: ~c"lib/sentry/client.ex", line: 124]},
      {:logger_backend, :call_handlers, 3,
       [file: ~c"logger_backend.erl", line: 51]},
      {:proc_lib, :exit_p, 3, [file: ~c"proc_lib.erl", line: 261]}
    ]
  ],

We recently got into a situation where the logger handler turned into sync mode and got stuck for a really long time. We would prefer to drop the messages instead of going to sync mode (which makes the situation even worse). We do have a rate limit configured, but this is hard to get right because the rate limit is local to a single process, whereas sentry API side rate limits are global.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jan 8, 2025
ananthakumaran added a commit to ananthakumaran/sentry-elixir that referenced this issue Jan 9, 2025
@ananthakumaran ananthakumaran linked a pull request Jan 9, 2025 that will close this issue
ananthakumaran added a commit to ananthakumaran/sentry-elixir that referenced this issue Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants