-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC interceptors #240
Comments
This project is based heavily on the [grpc-go-middleware libraries][1] and a [pull-request][2] from the [sentry-go library][3]. [1]: https://github.com/grpc-ecosystem/go-grpc-middleware [2]: getsentry/sentry-go#312 [3]: getsentry/sentry-go#240
Hi, I opened a draft pull request for this feature. Could someone please take a look? Any feedback would be appreciated. #312 |
Any updates on this. Should be very useful for anyone working with Grpc. Not sure why the PR is still in review |
Any update? x2 Still relevant |
Hi, I've been using a solution for myself by integrating the Grpc Erro and status package with Sentry. I'm open to contribute it here but not sure if this issue is still active or not. |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Any Update? |
Any update? x3 Still relevant |
It'd be nice if you could just click the notifications to get updates, without posting a comment that emails everyone else uselessly. When there's nothing to add to the discussion there's no need to comment. Anyway I have written this piece of code in the past based on Grpc status package: |
Summary
Provide gRPC interceptors to automatically capture errors and panics from servers and clients, both for unary and stream requests.
Motivation
gRPC is a high-performance, open source universal RPC framework originally developed by Google. It supports languages/platforms such as Python, Ruby, Kotlin and Go.
Go SDK already has some integrations with standard
net/http
package and some popular frameworks (like Gin, Martini and others).Similar to other frameworks, having standard Sentry integration will make it easier for users to integrate Sentry with gRPC.
Additional Context
gRPC has the concept of interceptor (middleware), which could make it easier to implement an official Sentry integration. An interceptor is a function with a specific signature/type:
Using an interceptor is also straightforward (pseudo-code):
The text was updated successfully, but these errors were encountered: