Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate JankStats library #2040

Closed
marandaneto opened this issue May 12, 2022 · 4 comments
Closed

Investigate JankStats library #2040

marandaneto opened this issue May 12, 2022 · 4 comments
Labels
enhancement New feature or request performance Performance API issues Platform: Android

Comments

@marandaneto
Copy link
Contributor

marandaneto commented May 12, 2022

Description

https://developer.android.com/topic/performance/jankstats (still in beta)

It could be a replacement for FrameMetricsAggregator
https://github.com/getsentry/sentry-java/blob/main/sentry-android-core/src/main/java/io/sentry/android/core/ActivityFramesTracker.java

The JanksStats library offers two additional capabilities that make it more dynamic and easier to use: jank heuristics and UI state.

@adinauer
Copy link
Member

Could extract the data bag that's available and put it on the transaction when sending to Sentry.

@adinauer
Copy link
Member

adinauer commented Oct 5, 2022

Related to getsentry/team-mobile#55

@marandaneto
Copy link
Contributor Author

Android now recommends improving for 90fps, which means ~11ms per frame instead of 60fps/~16ms, maybe we can consider this when working on the Mobile vitals and how we define slow/frozen frames threshold.

@romtsn
Copy link
Member

romtsn commented Jun 5, 2024

I feel like this is not needed anymore after we've implemented frame delay, #3099

@romtsn romtsn closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Performance API issues Platform: Android
Projects
Archived in project
Development

No branches or pull requests

4 participants