Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration for ktor #2684

Open
adinauer opened this issue May 2, 2023 · 7 comments
Open

Integration for ktor #2684

adinauer opened this issue May 2, 2023 · 7 comments

Comments

@adinauer
Copy link
Member

adinauer commented May 2, 2023

Problem Statement

This issue shall serve to gauge interest in a dedicated Sentry ktor integration. Please do upvote if this is something you'd like to see. You may also be interested in using our OpenTelemetry integration to get more info out of your ktor backend.

Please let us know which features you'd like to see. If you have any hints (i.e. provide an implementation of this to trace requests, ...) feel free to share 🙏 .

Solution Brainstorm

tbd

@romtsn
Copy link
Member

romtsn commented May 3, 2023

https://stackoverflow.com/a/75952971 for prior art

@elonzh
Copy link

elonzh commented Dec 19, 2023

Any updates?

@adinauer
Copy link
Member Author

Not yet @elonzh , please feel free to let us know which features you'd like to see in a ktor extension.

@amir-dropit
Copy link

@adinauer tracing for the Ktor http client requests would be great.
Like the one you offer for the Spring client
https://docs.sentry.io/platforms/java/guides/spring-boot/performance/instrumentation/automatic-instrumentation/

This would be relevant for both Android and Backend use cases

@adinauer
Copy link
Member Author

Hey everyone, we've just released 8.0.0-alpha.2 of the Java SDK, which has an improved version of our OpenTelemetry integration that supports ktor amongst many other libraries and frameworks. There's instructions how to upgrade in the changelog. If you decide to give it a try, any feedback is welcome 🙏 .

@smeubank
Copy link
Member

with #3752 will this be covered @adinauer ?

@adinauer
Copy link
Member Author

@smeubank only the performance part of the integration will. We could also capture errors, assuming there's a central point where those go through, similar to Spring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

6 participants