[Logs 6] Reduce amount of locking on every created log event #4380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
requested review from
romtsn,
stefanosiano,
markushi and
lcian
as code owners
|
Performance metrics 🚀
|
lcian
approved these changes
May 8, 2025
adinauer
changed the title
stefanosiano
approved these changes
May 12, 2025
Base automatically changed from
feat/log-batching-separate-executor-service
to
main
May 13, 2025 13:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
Reduce amount of locking on every created log event
💡 Motivation and Context
Previously every created log event would acquire the lock to check if it had to schedule.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps