From 08a3e71fbae2b9cbcaa0a45ecb6c3e22bacd1702 Mon Sep 17 00:00:00 2001
From: Luca Forstner <luca.forstner@sentry.io>
Date: Wed, 28 Aug 2024 13:33:35 +0000
Subject: [PATCH] Revert "ci: Update actions/upload-artifact to v4 (#13489)"

This reverts commit 14e56c7ef01705e960d563069f2974d0ca6d240d.
---
 .github/workflows/build.yml | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 576e2e7aa27c..7c62ead48726 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -185,7 +185,7 @@ jobs:
         with:
           name: build-output
           path: ${{ env.CACHED_BUILD_PATHS }}
-          retention-days: 4
+          retention-days: 7
           compression-level: 6
           overwrite: true
 
@@ -345,7 +345,6 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: ${{ github.sha }}
-          retention-days: 90
           path: |
             ${{ github.workspace }}/packages/browser/build/bundles/**
             ${{ github.workspace }}/packages/replay-internal/build/bundles/**
@@ -599,13 +598,11 @@ jobs:
         run: yarn test:ci${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}
 
       - name: Upload Playwright Traces
-        uses: actions/upload-artifact@v4
-        if: failure()
+        uses: actions/upload-artifact@v3
+        if: always()
         with:
-          name: playwright-traces-job_browser_playwright_tests-${{ matrix.bundle}}-${{matrix.project}}-${{matrix.shard || '0'}}
+          name: playwright-traces
           path: dev-packages/browser-integration-tests/test-results
-          overwrite: true
-          retention-days: 7
 
   job_browser_loader_tests:
     name: PW ${{ matrix.bundle }} Tests
@@ -651,13 +648,11 @@ jobs:
           cd dev-packages/browser-integration-tests
           yarn test:loader
       - name: Upload Playwright Traces
-        uses: actions/upload-artifact@v4
-        if: failure()
+        uses: actions/upload-artifact@v3
+        if: always()
         with:
-          name: playwright-traces-job_browser_loader_tests-${{ matrix.bundle}}
+          name: playwright-traces
           path: dev-packages/browser-integration-tests/test-results
-          overwrite: true
-          retention-days: 7
 
   job_check_for_faulty_dts:
     name: Check for faulty .d.ts files
@@ -1281,7 +1276,6 @@ jobs:
         with:
           name: ${{ steps.process.outputs.artifactName }}
           path: ${{ steps.process.outputs.artifactPath }}
-          retention-days: 7
 
   job_compile_bindings_profiling_node:
     name: Compile & Test Profiling Bindings (v${{ matrix.node }}) ${{ matrix.target_platform || matrix.os }}, ${{ matrix.node || matrix.container }}, ${{ matrix.arch || matrix.container }}, ${{ contains(matrix.container, 'alpine') && 'musl' || 'glibc'  }}