From 15dd865ab5493dd036ef42965b1d981a935f7f2e Mon Sep 17 00:00:00 2001
From: Tim Fish <tim@timfish.uk>
Date: Mon, 9 Sep 2024 11:28:20 +0200
Subject: [PATCH] test(node): Use fake timers to speed up unit tests (#13607)

Changes the rate-limiting tests to use fake timers. This takes the test
time from 24s to 4s.
---
 .../test/integrations/localvariables.test.ts  | 31 ++++++++++---------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/packages/node/test/integrations/localvariables.test.ts b/packages/node/test/integrations/localvariables.test.ts
index db9385214d42..ad9f6804d9a3 100644
--- a/packages/node/test/integrations/localvariables.test.ts
+++ b/packages/node/test/integrations/localvariables.test.ts
@@ -2,7 +2,7 @@ import { createRateLimiter } from '../../src/integrations/local-variables/common
 import { createCallbackList } from '../../src/integrations/local-variables/local-variables-sync';
 import { NODE_MAJOR } from '../../src/nodeVersion';
 
-jest.setTimeout(20_000);
+jest.useFakeTimers();
 
 const describeIf = (condition: boolean) => (condition ? describe : describe.skip);
 
@@ -87,10 +87,13 @@ describeIf(NODE_MAJOR >= 18)('LocalVariables', () => {
 
       for (let i = 0; i < 7; i++) {
         increment();
+        jest.advanceTimersByTime(100);
       }
+
+      jest.advanceTimersByTime(1_000);
     });
 
-    it('does not call disable if not exceeded', done => {
+    it('does not call disable if not exceeded', () => {
       const increment = createRateLimiter(
         5,
         () => {
@@ -101,20 +104,17 @@ describeIf(NODE_MAJOR >= 18)('LocalVariables', () => {
         },
       );
 
-      let count = 0;
-
-      const timer = setInterval(() => {
-        for (let i = 0; i < 4; i++) {
-          increment();
-        }
+      for (let i = 0; i < 4; i++) {
+        increment();
+        jest.advanceTimersByTime(200);
+      }
 
-        count += 1;
+      jest.advanceTimersByTime(600);
 
-        if (count >= 5) {
-          clearInterval(timer);
-          done();
-        }
-      }, 1_000);
+      for (let i = 0; i < 4; i++) {
+        increment();
+        jest.advanceTimersByTime(200);
+      }
     });
 
     it('re-enables after timeout', done => {
@@ -134,7 +134,10 @@ describeIf(NODE_MAJOR >= 18)('LocalVariables', () => {
 
       for (let i = 0; i < 10; i++) {
         increment();
+        jest.advanceTimersByTime(100);
       }
+
+      jest.advanceTimersByTime(10_000);
     });
   });
 });