From 561faff68201a816b84ccf87e7c84a08c6b08679 Mon Sep 17 00:00:00 2001 From: JonasBa Date: Tue, 10 Sep 2024 15:52:56 -0400 Subject: [PATCH] fix(profiling) segfault on close --- packages/profiling-node/bindings/cpu_profiler.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/profiling-node/bindings/cpu_profiler.cc b/packages/profiling-node/bindings/cpu_profiler.cc index a3756a92b39c..0acba0e37d7a 100644 --- a/packages/profiling-node/bindings/cpu_profiler.cc +++ b/packages/profiling-node/bindings/cpu_profiler.cc @@ -113,7 +113,12 @@ class MeasurementsTicker { void Cleanup() { uv_timer_stop(&timer); - uv_close(reinterpret_cast(&timer), nullptr); + + auto handle = reinterpret_cast(&timer); + + if(!uv_is_closing(handle)) { + uv_close(handle, free_timer_callback); + } } };