From 852681e9ff991dc0f393395ac9be5536e619c940 Mon Sep 17 00:00:00 2001 From: Andrei Borza Date: Tue, 3 Sep 2024 11:17:54 +0900 Subject: [PATCH] Retain traces on failure, fix test-results folder --- .github/workflows/build.yml | 2 +- dev-packages/e2e-tests/.gitignore | 1 - dev-packages/test-utils/src/playwright-config.ts | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index bbcea5235f83..c7d20491aaff 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1008,7 +1008,7 @@ jobs: if: failure() with: name: playwright-traces-job_e2e_playwright_tests-${{ matrix.test-application}} - path: dev-packages/e2e-tests/test-results + path: dev-packages/e2e-tests/test-applications/${{ matrix.test-application}}/test-results overwrite: true retention-days: 7 diff --git a/dev-packages/e2e-tests/.gitignore b/dev-packages/e2e-tests/.gitignore index 1de145432414..2ce9dc2100a5 100644 --- a/dev-packages/e2e-tests/.gitignore +++ b/dev-packages/e2e-tests/.gitignore @@ -4,4 +4,3 @@ tmp .tmp_build_stderr pnpm-lock.yaml .last-run.json -test-results diff --git a/dev-packages/test-utils/src/playwright-config.ts b/dev-packages/test-utils/src/playwright-config.ts index da2a10d0b477..d30c8cad4475 100644 --- a/dev-packages/test-utils/src/playwright-config.ts +++ b/dev-packages/test-utils/src/playwright-config.ts @@ -46,7 +46,7 @@ export function getPlaywrightConfig( baseURL: `http://localhost:${appPort}`, /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */ - trace: 'on-first-retry', + trace: 'retain-on-failure', }, /* Configure projects for major browsers */