From d130d7bcdbe8be610ad9abd1c4e2c40a683f24a4 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Tue, 18 Jul 2023 13:32:38 +0200 Subject: [PATCH] add instruction to release checklist --- docs/new-sdk-release-checklist.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/docs/new-sdk-release-checklist.md b/docs/new-sdk-release-checklist.md index 075068a68cc9..aca0f0f399c4 100644 --- a/docs/new-sdk-release-checklist.md +++ b/docs/new-sdk-release-checklist.md @@ -58,8 +58,13 @@ When you’re ready to make the first release, there are a couple of steps that - [ ] 1) If not yet done, be sure to remove the `private: true` property from your SDK’s `package.json`. Additionally, ensure that `"publishConfig": {"access": "public"}` is set. - [ ] 2) Make sure that the new SDK is **not added** in`[craft.yml](https://github.com/getsentry/sentry-javascript/blob/master/.craft.yml)` as a target for the **Sentry release registry**\ *Once this is added, craft will try to publish an entry in the next release which does not work and caused failed release runs in the past* -- [ ] 3) Make sure the new SDK is not excluded from the github & npm targets in `.craft.yml` -- [ ] 4) Cut a new release (as usual, via GH release action and Craft) +- [ ] 3) Add an `npm` target in `craft.yml` for the new package. Make sure to insert it in the right place, after all the Sentry dependencies of your package but before packages that depend on your new package (if applicable). + ```yml + - name: npm + id: npm:@sentry/[yourPackage] + includeNames: /^sentry-[yourPackage]-\d.*\.tgz$/ + ``` +- [ ] 4) Cut a new release (as usual, see [Publishing Release](https://github.com/getsentry/sentry-javascript/blob/develop/docs/publishing-a-release.md)) ### After the Release