-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to override only a few options for replayIntegration
#10305
Comments
me too |
Hi @mydea it looks like the issue is here for replay integration -
Reason - let me know if it is correct. I'll create a PR then. |
@Shubhdeep12 feel free to throw up a PR, I think that is correct |
ok great, added a PR @AbhiPrasad |
Before submitting a pull request, please take a look at our [Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md) guidelines and verify: - [ ] If you've added code that should be tested, please add tests. - [ ] Ensure your code lints and the test suite passes (`yarn lint`) & (`yarn test`). fixes: #10305
Is there an existing issue for this?
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/react
SDK Version
7.95.0
Framework Version
React 18.2.0
Link to Sentry event
No response
SDK Setup
Steps to Reproduce
Pass a few options to
replayIntegration
in a TypeScript file.Expected Result
Successful compilation - the changelog and migration docs make me think that this should work the same as
new Replay({ maskAllText: true, blockAllMedia: true })
.Actual Result
Compilation errors -
replayIntegration
is declared as needing a nearly completeReplayPluginOptions
object, so it complains if any options are missing.The text was updated successfully, but these errors were encountered: