Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency on rxjs #13162

Closed
3 tasks done
esetnik opened this issue Aug 1, 2024 · 3 comments · Fixed by #13166
Closed
3 tasks done

Missing dependency on rxjs #13162

esetnik opened this issue Aug 1, 2024 · 3 comments · Fixed by #13166
Assignees
Labels
Package: browser Issues related to the Sentry Browser SDK Type: Bug

Comments

@esetnik
Copy link

esetnik commented Aug 1, 2024

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/browser

SDK Version

8.22.0

Framework Version

@sentry/node

Link to Sentry event

No response

Reproduction Example/SDK Setup

// server.ts
import './instrument';
import * as Sentry from '@sentry/node';
// instrument.ts
import * as Sentry from '@sentry/node';

Sentry.init({
  dsn: 'https://xxxx',
});

Steps to Reproduce

  1. Upgrade to 8.22.0
  2. $ tsc --noEmit
    node_modules/@sentry/node/build/types/integrations/tracing/nest.d.ts:3:33 - error TS2307: Cannot find module 'rxjs' or its corresponding type declarations.

Expected Result

No typescript error. This only started happening in 8.22.0.

Actual Result

$ tsc --noEmit
node_modules/@sentry/node/build/types/integrations/tracing/nest.d.ts:3:33 - error TS2307: Cannot find module 'rxjs' or its corresponding type declarations.

3 import type { Observable } from 'rxjs';
~~~~~~

Found 1 error in node_modules/@sentry/node/build/types/integrations/tracing/nest.d.ts:3

@github-actions github-actions bot added the Package: browser Issues related to the Sentry Browser SDK label Aug 1, 2024
@nicohrubec
Copy link
Contributor

Hey, thanks for letting us know. Sorry about that! We are working on a bugfix and will cut a release today so you can upgrade. Will let you know when that goes out.

@nicohrubec
Copy link
Contributor

Hey, just to let you know we are having some problems with CI today so we are postponing the release to next week, but the issue should be fixed as soon as 8.23 is out.

@esetnik
Copy link
Author

esetnik commented Aug 2, 2024

No worries, I had to roll back to 8.20 anyway because of #13187 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: browser Issues related to the Sentry Browser SDK Type: Bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants