Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentation of NestJS functional middleware #13287

Open
Tracked by #12504
nicohrubec opened this issue Aug 9, 2024 · 0 comments
Open
Tracked by #12504

Instrumentation of NestJS functional middleware #13287

nicohrubec opened this issue Aug 9, 2024 · 0 comments
Labels
Package: nestjs Issues related to the Sentry Nestjs SDK

Comments

@nicohrubec
Copy link
Contributor

nicohrubec commented Aug 9, 2024

https://docs.nestjs.com/middleware#functional-middleware

Currently we have auto instrumentation for class based middleware. To do that we hook into the @Injectable decorator and patch the implemented use method on the class. However, nest also allows to add middlewares that are vanilla functions via app.use or the MiddlewareConsumer. These functional middlewares can be manually decorated with SentryTraced to get instrumentation but it would be better to have them auto-instumented.

@nicohrubec nicohrubec self-assigned this Aug 9, 2024
@nicohrubec nicohrubec added the Package: nestjs Issues related to the Sentry Nestjs SDK label Aug 9, 2024
@nicohrubec nicohrubec removed their assignment Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: nestjs Issues related to the Sentry Nestjs SDK
Projects
None yet
Development

No branches or pull requests

1 participant