Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glob is used wrong #13288

Closed
lforst opened this issue Aug 9, 2024 · 1 comment · Fixed by #13603
Closed

Glob is used wrong #13288

lforst opened this issue Aug 9, 2024 · 1 comment · Fixed by #13603
Assignees

Comments

@lforst
Copy link
Member

lforst commented Aug 9, 2024

Description

As raised through #13270, asset detection for sourcemap upload in Next.js doesn't work on Windows.

After some research we found that it is likely due to the glob library, not allowing \ characters except for escaping and us passing in globs with actual backslashes:

@andreiborza andreiborza self-assigned this Sep 5, 2024
andreiborza added a commit that referenced this issue Sep 6, 2024
Currently, we use `path.join` to provide sourcemap directories.
On Windows, the resulting strings would use `\` which is an escape
character for glob patterns and thus no sourcemaps would be found.

This fix ensures we use posix paths which glob then handles correctly
on Windows too.

Closes: #13270
Partly fixes: #13288
andreiborza added a commit that referenced this issue Sep 6, 2024
Currently, we use `path.join` to provide sourcemap directories.
On Windows, the resulting strings would use `\` which is an escape
character for glob patterns and thus no sourcemaps would be found.

This fix ensures we use posix paths which glob then handles correctly
on Windows too.

Closes: #13270
Partly fixes: #13288
@andreiborza andreiborza reopened this Sep 8, 2024
@lforst
Copy link
Member Author

lforst commented Nov 6, 2024

@andreiborza I think we can close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants