-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glob is used wrong #13288
Labels
Comments
andreiborza
added a commit
that referenced
this issue
Sep 6, 2024
Currently, we use `path.join` to provide sourcemap directories. On Windows, the resulting strings would use `\` which is an escape character for glob patterns and thus no sourcemaps would be found. This fix ensures we use posix paths which glob then handles correctly on Windows too. Closes: #13270 Partly fixes: #13288
andreiborza
added a commit
that referenced
this issue
Sep 6, 2024
Currently, we use `path.join` to provide sourcemap directories. On Windows, the resulting strings would use `\` which is an escape character for glob patterns and thus no sourcemaps would be found. This fix ensures we use posix paths which glob then handles correctly on Windows too. Closes: #13270 Partly fixes: #13288
@andreiborza I think we can close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
As raised through #13270, asset detection for sourcemap upload in Next.js doesn't work on Windows.
After some research we found that it is likely due to the glob library, not allowing
\
characters except for escaping and us passing in globs with actual backslashes:sentry-javascript/packages/nextjs/src/config/webpackPluginOptions.ts
Lines 24 to 35 in b17ac59
windowsPathsNoEscape
in the case we are autodetecting, because we are exclusively passing absolute paths to glob)The text was updated successfully, but these errors were encountered: