Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataloaderIntegration to Node #13313

Closed
5 tasks
Tracked by #13317
mydea opened this issue Aug 12, 2024 · 1 comment · Fixed by #13664
Closed
5 tasks
Tracked by #13317

Add dataloaderIntegration to Node #13313

mydea opened this issue Aug 12, 2024 · 1 comment · Fixed by #13664
Assignees
Labels
Package: node Issues related to the Sentry Node SDK Package-Meta: OpenTelemetry

Comments

@mydea
Copy link
Member

mydea commented Aug 12, 2024

Description

We want to instrument dataloader. There is an existing OTEL instrumentation for this:

https://www.npmjs.com/package/@opentelemetry/instrumentation-dataloader

Tasks

This is a cache integration, and thus must follow https://develop.sentry.dev/sdk/telemetry/traces/modules/caches/. You can see https://docs.sentry.io/platforms/javascript/guides/node/tracing/instrumentation/custom-instrumentation/caches-module/ for a reference, or look at the redis integration.

@mydea mydea changed the title Add dataloaderIntegration to node Add dataloaderIntegration to Node Aug 12, 2024
@onurtemizkan onurtemizkan self-assigned this Aug 29, 2024
@AbhiPrasad
Copy link
Member

Follow up tasks documented in #13724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: node Issues related to the Sentry Node SDK Package-Meta: OpenTelemetry
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants