Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profilingNode does not include prebuilt binaries for Node 23 #14475

Open
damianobarbati opened this issue Nov 25, 2024 · 2 comments
Open

profilingNode does not include prebuilt binaries for Node 23 #14475

damianobarbati opened this issue Nov 25, 2024 · 2 comments
Labels
Feature: Profiling Package: profiling-node Issues related to the Sentry Profiling Node SDK

Comments

@damianobarbati
Copy link

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

Inside a node:23.2-alpine image I can't run my node --import sentry.ts index.ts:

import * as Sentry from '@sentry/node';
import { nodeProfilingIntegration } from '@sentry/profiling-node';
import commonSentryConfig from 'common/commonSentryConfig.ts';
import ENV from '#api/env.ts';

Sentry.init({
    dsn: ENV.SENTRY_DSN,
    environment: ENV.APP_ENV,
    integrations: [nodeProfilingIntegration()],
    tracesSampleRate: 1.0,
    profilesSampleRate: 1.0,
  });

  Sentry.setTag('application', 'api');
}

I get a:

Error: Cannot find module '/mnt/node_modules/.pnpm/@[email protected]/node_modules/@sentry/profiling-node/lib/sentry_cpu_profiler-linux-x64-musl-131.node'

@JonasBa I see something similar recently happened and it was fixed here => #12169

Should some binary be released to support node v23 on alpine?

Expected Result

Initializing Sentry should not raise an exception due to a missing binary.

Actual Result

Initializing Sentry throws an error.

Product Area

Profiling

Link

No response

DSN

No response

Version

No response

@getsantry
Copy link

getsantry bot commented Nov 25, 2024

Assigning to @getsentry/support for routing ⏲️

@InterstellarStella InterstellarStella transferred this issue from getsentry/sentry Nov 26, 2024
@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 3 Nov 26, 2024
@chargome
Copy link
Member

chargome commented Nov 26, 2024

Hi @damianobarbati, thanks for reaching out! We only ship prebuilt binaries for node 16, 18, 20, 22.

See https://github.com/getsentry/sentry-javascript/tree/develop/packages/profiling-node#building-the-package-from-source

@mydea mydea changed the title Cannot find module when using node v23? profilingNode does not include prebuilt binaries for Node 23 Nov 27, 2024
@mydea mydea added Feature: Profiling Package: profiling-node Issues related to the Sentry Profiling Node SDK labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Profiling Package: profiling-node Issues related to the Sentry Profiling Node SDK
Projects
Status: No status
Development

No branches or pull requests

3 participants