Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate spanId on PropagationContext #14255

Closed
lforst opened this issue Nov 13, 2024 · 0 comments · Fixed by #14482
Closed

Deprecate spanId on PropagationContext #14255

lforst opened this issue Nov 13, 2024 · 0 comments · Fixed by #14482
Assignees
Milestone

Comments

@lforst
Copy link
Member

lforst commented Nov 13, 2024

Description

As per #12385 we have determined that spanId on the propagationContext is problematic and we want to replace it with other mechanisms.

This is architecturally solved by decoupling the performance part of the SDK from the propagation context. The Propagation context was not designed to feed data to the performance part of the SDK. The propagation context was desinged as part of "tracing without performance". Performance data may feed into the propagation context but not the other way around. When we have non-performance events (ie Errors, Replays, Metrics, whatever), they should first look at current performance context (ie active span) and only as a fallback look at the propagation context. If a span ID is required for a payload and no active span is available, a random span ID should be generated instead.

@lforst lforst added this to the 9.0.0 milestone Nov 13, 2024
@lforst lforst changed the title [v9] Deprecate spanId on PropagationContext Deprecate spanId on PropagationContext Nov 13, 2024
@mydea mydea closed this as completed in 17396a1 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants