Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nextjs] Handle more cases when auto-instrumenting tracing #5827

Closed
1 of 6 tasks
lobsterkatie opened this issue Sep 27, 2022 · 4 comments
Closed
1 of 6 tasks

[nextjs] Handle more cases when auto-instrumenting tracing #5827

lobsterkatie opened this issue Sep 27, 2022 · 4 comments

Comments

@lobsterkatie
Copy link
Member

lobsterkatie commented Sep 27, 2022

There are a number of cases (some edge-case-y, some not) where we still don't fully support tracing in the nextjs SDK.

  • Have spans for getInitialProps when run client-side
  • Handle non-props responses from data-fetchers (redirects, etc)
  • Add instrumentation for how long server-side rendering takes
  • Support tracing when using a custom server (related: @sentry/nextjs and nextjs custom server #3782)
  • Automatically wrap getStaticProps (Wrapper exists but we don't have access to the request. Is this solvable? Do we even care, given that this generally runs in the background?)
  • Middleware support (this is a bigger conversation - tracked in Next.js middleware support #4206)
@ikryvorotenko
Copy link

is there an update on GetStaticProps? I can see it only needs some transaction creation logic.

Also, is there a workaround to make GetStaticProps instrumentation work? Like somehow passing the register an active transaction before GetStaticProps is called.

@lforst
Copy link
Member

lforst commented May 2, 2023

is there an update on GetStaticProps? I can see it only needs some transaction creation logic.

@ikryvorotenko Currently we don't have this on our short-term backlog. PRs welcome!

Also, is there a workaround to make GetStaticProps instrumentation work? Like somehow passing the register an active transaction before GetStaticProps is called.

You should just be able to start a transaction at the start of GSP and finish it at the end.

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Jul 27, 2023

@lforst Closing this issue - but lmk if we need to re-open.

@lforst
Copy link
Member

lforst commented Jul 27, 2023

@AbhiPrasad closing is fine! most of this is tracked elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants