Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Rewrite abs_path frames #7619

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Conversation

lforst
Copy link
Member

@lforst lforst commented Mar 27, 2023

Fixes #7500

In #7167 we put abs_path onto the stack frame object in error events. abs_path is used by symbolicator to resolve source maps and since we now have it on the stack frame it is not backfilled anymore in Relay.

This change caused source maps to break in the Next.js SDK because we do some frame rewriting to account for asset prefixes and URL decoding issues.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.57 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 64.2 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 56.58 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.59 KB (0%)
@sentry/browser - Webpack (minified) 71.66 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.61 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.99 KB (+0.23% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.93 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.1 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.37 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 38.44 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.59 KB (-0.01% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.1 KB (-0.01% 🔽)

@lforst lforst marked this pull request as ready for review March 27, 2023 10:58
@lforst lforst requested review from AbhiPrasad and mydea March 27, 2023 10:58
@lforst lforst merged commit b589685 into develop Mar 27, 2023
@lforst lforst deleted the lforst-fix-abs-path-nextjs branch March 27, 2023 11:41
@badtant
Copy link

badtant commented Jun 17, 2023

Hi,
I'm still having trouble with sourcemaps.

This fix was for the #7167 change and was released in 7.46.0.
But in the same release there was a revert of #7167. It was made in #7623.

My guess is that this should also be reverted then?

@lforst
Copy link
Member Author

lforst commented Jun 19, 2023

Yeah we should probably revert this too. However, I don't think that this would realistically change anything.

@badtant
Copy link

badtant commented Jun 20, 2023

Cool, maybe it isn't this change that got us into trouble. Started a discussion here: #8370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stacktraces not source mapped after upgrading from 7.26 to 7.42 (Next.js assetPrefix)
3 participants